← Back to team overview

dulwich-users team mailing list archive

Re: [PATCH] Allow accessing invalidly named refs, but don't allow setting them.

 

On Sun, Jan 16, 2011 at 22:04, Jelmer Vernooij <jelmer@xxxxxxxxxxx> wrote:

> We discussed invalidly named refs earlier, and allowing to access them
> but raising exceptions when the user attempts to set them.
>
> Does this seem like a reasonable patch?
>

Sounds reasonable. I didn't think C git allowed this, but I checked and it
seems it does:
$ cp .git/refs/heads/master .git/refs/test/foo..bar......baz
$ git rev-parse refs/test/foo..bar......baz
c6df1f81a8a24d198c5bb32b9d27e2812f49195b
$ git check-ref-format refs/test/foo..bar......baz || echo "bad ref"
bad ref

However, I can't seem to apply the patch against the upstream master
(f841bf0). Looking at the first few diffs, it looks like this is against an
older version?



> Cheers,
>
> Jelmer
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dulwich-users
> Post to     : dulwich-users@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dulwich-users
> More help   : https://help.launchpad.net/ListHelp
>
>

References