← Back to team overview

dulwich-users team mailing list archive

Re: [PATCH 08/33] server: Fix short-circuit behavior for no-op fetches.

 

On Fri, Jul 29, 2011 at 09:21, Dave Borowitz <dborowitz@xxxxxxxxxx> wrote:

> On Fri, Jul 29, 2011 at 03:22, Jelmer Vernooij <jelmer@xxxxxxxxx> wrote:
>
>> On Wed, 2011-07-27 at 22:45 -0700, dborowitz@xxxxxxxxxx wrote:
>> > The previous behavior failed with an AttributeError that was being
>> > silently swallowed by the server code. It still passed tests because the
>> > pipe was getting closed, which was what the client expected anyway.
>> >
>> > Now that this error is no longer swallowed, we needed to actually fix
>> > the behavior.
>> This breaks check-compat for me by making it hang. I haven't
>> investigated further, so and simply skipped this patch for the moment.
>>
>
> Huh, I can't reproduce on 2.6 on lucid, either in my series or
> cherry-picked onto current master. What's your environment like?
>

Nor can I reproduce on 2.7 on lucid.


>  The other ones have all been applied.
>>
>> Cheers,
>>
>> Jelmer
>>
>
>

Follow ups

References