← Back to team overview

dulwich-users team mailing list archive

Re: Deprecate Repo.revision_history()?

 

On Mon, Aug 1, 2011 at 10:20, Jelmer Vernooij <jelmer@xxxxxxxxx> wrote:

> Dave's recent changes replace the implementation of
> Repo.revision_history() with a simple call to Walker.
>
> Since this is the only graph-related function in Repo at the moment, I
> wonder if it would make sense to deprecate it. In all but the simplest
> case it's probably a better idea to use Walker. Repo also already has
> enough methods as-is.
>
> Alternatively, perhaps we can just provide a .get_walker() method
> toreplace .revision_history() which is more discoverable ?
>

I support some sort of get_walker method, preferably with kwargs to expose
all the Walker functionality.

This stuff all lives in a separate module because it's a lot of
functionality, but IMO it's nice when writing scripts to be able to just
depend on repo.


> Thoughts?
>
> Cheers,
>
> Jelmer
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dulwich-users
> Post to     : dulwich-users@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dulwich-users
> More help   : https://help.launchpad.net/ListHelp
>
>

References