← Back to team overview

dulwich-users team mailing list archive

Re: dulwich porcelain

 

Am Friday, den 14.09.2012, 11:48 -0700 schrieb Mark Mikofski:
> > This function seems a lot more complicated than it needs to be. Note
> > that it's not necessary to find the refs that differ - it's fine to
> > update a ref even if it already exists.
> > 
> 
> OK, then the update_refs function can just be
>     `lambda old: r.get_refs()
Basically - though you might want to still strip HEAD.

> Does that seem right? Why does send_pack pass old_refs to
> update_refs (previously called determine_wants) if it isn't needed?
> Or what is old_refs needed for?
Some implementations of update_refs care about the old refs. For
example, if they want to error out if there are non-fast forward
updates.

Cheers,

Jelmer

Attachment: signature.asc
Description: This is a digitally signed message part


References