← Back to team overview

dulwich team mailing list archive

Re: [PATCH 1/3] Lazily read the contents of ShaFiles from disk.

 

Sure, I'll push them to my github repo shortly.

On Mon, Apr 12, 2010 at 16:22, Jelmer Vernooij <jelmer@xxxxxxxxx> wrote:

> Hi Dave,
>
> On Mon, 2010-04-12 at 08:47 -0700, dborowitz@xxxxxxxxxx wrote:
> > From: Dave Borowitz <dborowitz@xxxxxxxxxx>
> >
> > Previously, ShaFile.from_file read and inflated the entire contents of a
> > ShaFile, storing the inflated text in memory. Parsing that text was done
> > lazily, but this resulted in a confusing performance profile, since the
> > "lazy" part was in fact faster (memory/CPU-bound) than the eager part
> > (I/O-bound).
> Any chance you can push these revisions up to a git repository
> somewhere? The patches don't apply cleanly, so being able to use merge
> would be nice.
>
> Cheers,
>
> Jelmer
>

Follow ups

References