duplicity-team team mailing list archive

[edso <edgar.soldin@xxxxxx>]

edso has proposed merging lp:~ed.so/duplicity/ssh-pexpect-msgbug into lp:duplicity.

Requested reviews:
  duplicity-team (duplicity-team)

For more details, see:
https://code.launchpad.net/~ed.so/duplicity/ssh-pexpect-msgbug/+merge/127153

probably fix

    File "/usr/local/lib/python2.7/dist-packages/duplicity/backends/_ssh_pexpect.py", line 223, in run_sftp_command
        log.Warn("Running '%s' with commands:\n %s\n failed (attempt #%d): %s" % (commandline, "\n ".join(commands), n, msg))
    UnboundLocalError: local variable 'msg' referenced before assignment

-- 
https://code.launchpad.net/~ed.so/duplicity/ssh-pexpect-msgbug/+merge/127153
Your team duplicity-team is requested to review the proposed merge of lp:~ed.so/duplicity/ssh-pexpect-msgbug into lp:duplicity.

=== modified file 'duplicity/backends/_ssh_pexpect.py'
--- duplicity/backends/_ssh_pexpect.py	2012-05-15 11:34:57 +0000
+++ duplicity/backends/_ssh_pexpect.py	2012-09-30 13:18:32 +0000
@@ -173,6 +173,7 @@
             cmdloc = 0
             passprompt = 0
             while 1:
+                msg = ""
                 match = child.expect(responses,
                                      searchwindowsize=maxread+max_response_len)
                 log.Debug("State = sftp, Before = '%s'" % (child.before.strip()))