duplicity-team team mailing list archive

[Michael Terry <michael.terry@xxxxxxxxxxxxx>]

The proposal to merge lp:~mterry/duplicity/gpg-encode into lp:duplicity has been updated.

Description changed to:

getpass.getpass(prompt) eventually calls str(prompt).  Which is a no go, if the prompt contains unicode.  Here's a patch to always pass getpass() a byte string.

Our tests didn't catch this because they always set PASSPHRASE.  I've added a test that passes the passphrase via stdin.

In order to actually test the bug condition (_() returning unicode strings that can't convert to ascii), I added a gettext.py override that always adds an invisible unicode character to returned strings when testing.  This way, we should be able to catch future ascii translation problems in any of the code under test.

Oh, and while I was at it, I removed the useless gettext.install() lines in bin/duplicity and bin/rdiffdir (the gettext.install() call in duplicity/__init__.py is what matters).

For more details, see:
https://code.launchpad.net/~mterry/duplicity/gpg-encode/+merge/204808
-- 
https://code.launchpad.net/~mterry/duplicity/gpg-encode/+merge/204808
Your team duplicity-team is requested to review the proposed merge of lp:~mterry/duplicity/gpg-encode into lp:duplicity.