duplicity-team team mailing list archive

[edso <edgar.soldin@xxxxxx>]

A+ for effort ;) .. we should probably make that a 0.7 release, stating that there might be some hickups (bugs) due to major code revision.
two more comments below.. 

On 28.04.2014 04:55, Michael Terry wrote:
SNIP
> 
> 
> === modified file 'bin/duplicity'
> --- bin/duplicity	2014-04-19 19:54:54 +0000
> +++ bin/duplicity	2014-04-28 02:49:55 +0000
> @@ -289,8 +289,6 @@
>  
>      def validate_block(orig_size, dest_filename):
>          info = backend.query_info([dest_filename])[dest_filename]
> -        if 'size' not in info:
> -            return # backend didn't know how to query size

this could raise a key not found error. can you really guaratee the key will be there?

>          size = info['size']
>          if size is None:
>              return # error querying file
> 
> === modified file 'duplicity/backend.py'
> --- duplicity/backend.py	2014-04-25 23:53:46 +0000
> +++ duplicity/backend.py	2014-04-28 02:49:55 +0000
> @@ -24,6 +24,7 @@
SNIP
>  
>  # These URL schemes have a backend with a notion of an RFC "network location".
>  # The 'file' and 's3+http' schemes should not be in this list.
> @@ -69,7 +74,6 @@
>  uses_netloc = ['ftp',
>                 'ftps',
>                 'hsi',
> -               'rsync',
>                 's3',
>                 'scp', 'ssh', 'sftp',
>                 'webdav', 'webdavs',

any reason why you removed rsync here?

..ede

-- 
https://code.launchpad.net/~mterry/duplicity/backend-unification/+merge/216764
Your team duplicity-team is requested to review the proposed merge of lp:~mterry/duplicity/backend-unification into lp:duplicity.