← Back to team overview

duplicity-team team mailing list archive

Re: [Merge] lp:~mterry/duplicity/backend-unification into lp:duplicity

 

> this could raise a key not found error. can you really guaratee the key will be there?

Yes, because now query_info calls the backend query function, then makes sure that 'size' exists for each filename passed.  This was part of the "allow backends to be dumb" strategy -- if they skip a filename or don't provide 'size', the rest of duplicity doesn't have to care.  Guarantees come from the wrapper class, not the backends.

> any reason why you removed rsync here?

Yeah, I changed the rsync backend to support relative/local urls.  This was so we could test it as part of our normal automated tests (without needing a server).  The list I removed 'rsync' from was a list of backends that require a hostname.
-- 
https://code.launchpad.net/~mterry/duplicity/backend-unification/+merge/216764
Your team duplicity-team is requested to review the proposed merge of lp:~mterry/duplicity/backend-unification into lp:duplicity.


Follow ups

References