← Back to team overview

duplicity-team team mailing list archive

Re: [Merge] lp:~ed.so/duplicity/paramiko.identyfile into lp:duplicity

 

On 10.12.2014 20:59, Kenneth Loafman wrote:
> The fix should be in commandline.py where it simply extends the list of ssh options in a list. It should instead split any quoted strings into individual options based on the rules you established in your manpage changes, then append those options to the list, thus getting rid of the quotes.

would be elegant, but this works fine for most cases and is ready now. if you do not like it just merge the manpage please, so i don't have to rebase it later.

> 
> Also, the paramiko backend assumes that globals.ssh_options is a string.  If I read it right, commandline makes globals.ssh_options into a list (based on the verb extend rather than append).
> 

nope, it's a string, based on reading the source ;)
 http://bazaar.launchpad.net/~duplicity-team/duplicity/0.7-series/view/head:/duplicity/commandline.py#L164

..ede

-- 
https://code.launchpad.net/~ed.so/duplicity/paramiko.identyfile/+merge/244347
Your team duplicity-team is requested to review the proposed merge of lp:~ed.so/duplicity/paramiko.identyfile into lp:duplicity.


References