duplicity-team team mailing list archive

[Aaron Whitehouse <lists@xxxxxxxxxxxxxxxxxx>]

Aaron Whitehouse has proposed merging lp:~hooloovoo/duplicity/add-else-to-badupload-try-except into lp:duplicity.

Requested reviews:
  duplicity-team (duplicity-team)

For more details, see:
https://code.launchpad.net/~hooloovoo/duplicity/add-else-to-badupload-try-except/+merge/245396

See commit. Badupload test previously did not have an else in the try-except. The test passed if the except was triggered, but would also pass if the test did not trigger an error at all.
-- 
Your team duplicity-team is requested to review the proposed merge of lp:~hooloovoo/duplicity/add-else-to-badupload-try-except into lp:duplicity.

=== modified file 'testing/functional/test_badupload.py'
--- testing/functional/test_badupload.py	2014-04-21 19:21:45 +0000
+++ testing/functional/test_badupload.py	2014-12-27 15:21:40 +0000
@@ -38,6 +38,8 @@
             self.fail()
         except CmdError as e:
             self.assertEqual(e.exit_status, 44, str(e))
+        else:
+            self.fail('Expected CmdError not thrown')
 
 if __name__ == "__main__":
     unittest.main()