← Back to team overview

duplicity-team team mailing list archive

Re: [Duplicity-talk] new librsync release

 

nothing to add, sounds reasonable all around.. ede

On 31.01.2015 16:41, Kenneth Loafman wrote:
> Thanks for the correction.  I had missed that flag.
> 
> I'm looping in duplicity-team on this.  Perhaps they have something to add
> as well.
> 
> ...Ken
> 
> 
> On Sat, Jan 31, 2015 at 9:29 AM, Martin Pool <mbp@xxxxxxxxxxxxxx> wrote:
> 
>> On Fri, Jan 30, 2015 at 6:46 AM, Kenneth Loafman <kenneth@xxxxxxxxxxx>
>> wrote:
>>
>>> Hi,
>>>
>>> OK, duplicity just got it's first bug report about this:
>>> https://bugs.launchpad.net/bugs/1416344
>>>
>>> What this upgrade means is that a signature goes from 16 bytes to 32
>>> bytes, and while the old sig files can be read, they can no longer be
>>> written.
>>>
>>
>> You can write the old signature format by passing RS_MD4_SIG_MAGIC
>> <https://github.com/librsync/librsync/blob/master/librsync.h#L102> when
>> starting signature generation. It might be reasonable to have a
>> back-compatibility option in duplicity, but it shouldn't be the default.
>>
>>
>>> To me, this fix implies a major version change since it will be a major
>>> format change and a doubling of the already large sig file.  I'm thinking
>>> this should be staged along with the split signature files and targeted to
>>> version 0,8 of duplicity.  There may be other concerns that I'm missing.
>>>
>>
>> I agree it should be a major release.
>>
>>>
>>> Thoughts?
>>>
>>> ...Ken
>>>
>>>
>>> On Fri, Jan 23, 2015 at 10:43 AM, Martin Pool <mbp@xxxxxxxxxxxxxx> wrote:
>>>
>>>> Hi,
>>>>
>>>> I've just made a new librsync release <
>>>> https://github.com/librsync/librsync/releases/tag/v1.0.0>.
>>>>
>>>> This includes a fix for a security bug reported by therealmik that's
>>>> relevant to Duplicity, <https://github.com/librsync/librsync/issues/5>.
>>>>
>>>> Unfortunately the fix for this necessitates a change in signature file
>>>> format, so probably also a new version of the Duplicity archive format.
>>>> librsync can read the old format but writing it is deprecated.
>>>>
>>>> Regards,
>>>> --
>>>> Martin
>>>>
>>>> _______________________________________________
>>>> Duplicity-talk mailing list
>>>> Duplicity-talk@xxxxxxxxxx
>>>> https://lists.nongnu.org/mailman/listinfo/duplicity-talk
>>>>
>>>>
>>>
>>> _______________________________________________
>>> Duplicity-talk mailing list
>>> Duplicity-talk@xxxxxxxxxx
>>> https://lists.nongnu.org/mailman/listinfo/duplicity-talk
>>>
>>>
>>
>>
>> --
>> Martin
>>
>> _______________________________________________
>> Duplicity-talk mailing list
>> Duplicity-talk@xxxxxxxxxx
>> https://lists.nongnu.org/mailman/listinfo/duplicity-talk
>>
>>
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~duplicity-team
> Post to     : duplicity-team@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~duplicity-team
> More help   : https://help.launchpad.net/ListHelp
> 


References