duplicity-team team mailing list archive

[Eugene Crosser <crosser@xxxxxxxxxxx>]

Eugene Crosser has proposed merging lp:~crosser/duplicity/fix-small-file-upload into lp:duplicity.

Requested reviews:
  duplicity-team (duplicity-team)

For more details, see:
https://code.launchpad.net/~crosser/duplicity/fix-small-file-upload/+merge/334326

I initially guessed that it was a bug in the Dropbox API and opened a ticket
https://github.com/dropbox/dropbox-sdk-python/issues/131
but it turns out that is was a deliberate breakage. Thus, this update is necessary.

After all three fixes, backup to dropbox works for me once again! Yay!
-- 
Your team duplicity-team is requested to review the proposed merge of lp:~crosser/duplicity/fix-small-file-upload into lp:duplicity.

=== modified file 'duplicity/backends/dpbxbackend.py'
--- duplicity/backends/dpbxbackend.py	2017-11-25 22:12:14 +0000
+++ duplicity/backends/dpbxbackend.py	2017-11-27 20:12:03 +0000
@@ -215,7 +215,7 @@
         try:
             log.Debug('dpbx,files_upload(%s, [%d bytes])' % (remote_path, file_size))
 
-            res_metadata = self.api_client.files_upload(f, remote_path,
+            res_metadata = self.api_client.files_upload(f.read(), remote_path,
                                                         mode=WriteMode.overwrite,
                                                         autorename=False,
                                                         client_modified=None,