duplicity-team team mailing list archive

[edso <edgar.soldin@xxxxxx>]

maybe this helps

https://bazaar.launchpad.net/~duplicity-team/duplicity/0.8-series/view/head:/testing/manual/backendtest#L60
should probably use 'get_backend' instead of 'get_backend_object'
https://bazaar.launchpad.net/~duplicity-team/duplicity/0.8-series/view/head:/duplicity/backend.py#L216
which properly wraps the backend in BackendWrapper()

like it is done in current duplicity, see
https://bazaar.launchpad.net/~duplicity-team/duplicity/0.8-series/view/head:/duplicity/commandline.py#L1043

..ede/duply.net


On 02.12.2019 17:57, Kenneth Loafman wrote:
> Don't know.  I know that duplicity requires bytes.  I have not used the
> manual backend test in a while, so it may be out  of date.
>
> On Mon, Dec 2, 2019 at 8:21 AM edso <edgar.soldin@xxxxxx> wrote:
>
>> hey Ken,
>>
>> i see that for other backends this is done automagically in
>>
>> https://bazaar.launchpad.net/~duplicity-team/duplicity/0.8-series/view/head:/duplicity/backend.py#L562
>>
>> can any of you see a reason why it is not for the boto3 backend?.. ede
>>
>>
>> On 02.12.2019 15:12, Kenneth Loafman wrote:
>>> Yes, it needs to be bytes.  Use util.fsencode() to convert.
>>>
>>>
>>>
>>> On Sun, Dec 1, 2019 at 5:02 PM carlalex <carlalex@xxxxxxxxxxxxx> wrote:
>>>
>>>> So, the test failures in manual/backendtest are in test_delete and
>>>> test_list.  I think the backend is actually listing and deleting as I
>> would
>>>> expect, but the test is failing due to a type mismatch.  These tests as
>>>> written are looking for files names b'a' and b'b', but list is returning
>>>> then as regular (unicode?) strings, not byte strings.
>>>>
>>>> In this case, I am not sure if the test is wrong, or if I should change
>>>> the backend to return byte strings in list rather than unicode strings.
>>>>
>>>> --
>>>> https://code.launchpad.net/~carlalex/duplicity/duplicity/+merge/376206
>>>> You are subscribed to branch lp:duplicity.
>>>>
>>>
>>
>>
>> --
>> https://code.launchpad.net/~carlalex/duplicity/duplicity/+merge/376206
>> You are subscribed to branch lp:duplicity.
>>
>


-- 
https://code.launchpad.net/~carlalex/duplicity/duplicity/+merge/376206
Your team duplicity-team is subscribed to branch lp:duplicity.