dx-packages team mailing list archive

[PS Jenkins bot <ps-jenkins@xxxxxxxxxxxxxxxxxxx>]

Fix committed into lp:indicator-network at revision None, scheduled for
release in indicator-network, milestone Unknown

** Changed in: indicator-network
       Status: In Progress => Fix Committed

** Changed in: indicator-location
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to indicator-sound in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1233679

Title:
  Incorrect translation's template handling since the switch to cmake

Status in Indicator Location:
  Fix Committed
Status in Network Menu:
  Fix Committed
Status in The Session Menu:
  Fix Committed
Status in Sound Menu:
  Fix Committed
Status in “indicator-sound” package in Ubuntu:
  New
Status in “pkgbinarymangler” package in Ubuntu:
  New

Bug description:
  The switch to cmake seems to have made the translation setup a bit
  harder to deal with

  * Doing that in the source

  $ mkdir build
  $ cd build
  $ cmake ..
  $ make

  leads to a build dir without po subdir/template

  
  * The Ubuntu magic seems to be not working anymore:
  https://launchpadlibrarian.net/151894146/buildlog_ubuntu-saucy-i386.indicator-sound_12.10.2%2B13.10.20130930-0ubuntu1_UPLOADING.txt.gz

  "Building ${CMAKE_PROJECT_NAME}.pot...
  ...
  None of the files in POTFILES.in contain strings marked for translation.
  dh_langpack: processing files to add translation domain '${CMAKE_PROJECT_NAME}'.."

  dh_translations does that

  "            while (<CMAKELISTSFILE>) {
                  if ( -e 'po/POTFILES.in' ) {
                       $use_intltool = 1;
                  }
                  $domain = $1 if /^set\s*\(GETTEXT_PACKAGE\s*"?([^\s"]*)"?\s*\)/;"

  That doesn't work great with the cmakefilelist having
  "set(GETTEXT_PACKAGE ${CMAKE_PROJECT_NAME})" (e.g it doesn't know to
  escape it)

  
  * There doesn't seem to be a standard makefile target to update the pot? Well at least those don't work
  $ make pot
  $ make translations
  $ make update-pot
  $ make indicator-sound.pot

  
  The result is that currently the list of string handed to translations is not updated as it should :/

To manage notifications about this bug go to:
https://bugs.launchpad.net/indicator-location/+bug/1233679/+subscriptions