dx-packages team mailing list archive

[Launchpad Bug Tracker <1233679@xxxxxxxxxxxxxxxxxx>]

This bug was fixed in the package indicator-network -
0.5.1+13.10.20131004-0ubuntu1

---------------
indicator-network (0.5.1+13.10.20131004-0ubuntu1) saucy; urgency=low

  [ Pete Woods ]
  * Add network manager secret agent.
    * Interfaces with unity8's extended snap decisions.

  [ Charles Kerr ]
  * One-liner to set GETTEXT_PACKAGE explicitly because dh_translations
    can't handle ${CMAKE_PROJECT_NAME}. (LP: #1233679)

  [ Ted Gould ]
  * Drop Airplane Mode for Phone 1.0. (LP: #1232832)
  * Update settings URL to settings:///system. (LP: #1231444)
  * Remove icons that have made it into the theme.
  * Depend on XDG Python lib for the Apport hook. (LP: #1233138)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 291
 -- Ubuntu daily release <ps-jenkins@xxxxxxxxxxxxxxxxxxx>   Fri, 04 Oct 2013 02:29:39 +0000

** Changed in: indicator-network (Ubuntu)
       Status: New => Fix Released

** Branch linked: lp:ubuntu/saucy-proposed/indicator-network

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to indicator-sound in Ubuntu.
Matching subscriptions: dx-packages, dx-packages
https://bugs.launchpad.net/bugs/1233679

Title:
  Incorrect translation's template handling since the switch to cmake

Status in Indicator Location:
  Fix Committed
Status in Network Menu:
  Fix Committed
Status in The Session Menu:
  Fix Committed
Status in Sound Menu:
  Fix Committed
Status in “indicator-location” package in Ubuntu:
  New
Status in “indicator-network” package in Ubuntu:
  Fix Released
Status in “indicator-session” package in Ubuntu:
  New
Status in “indicator-sound” package in Ubuntu:
  New
Status in “pkgbinarymangler” package in Ubuntu:
  New

Bug description:
  The switch to cmake seems to have made the translation setup a bit
  harder to deal with

  * Doing that in the source

  $ mkdir build
  $ cd build
  $ cmake ..
  $ make

  leads to a build dir without po subdir/template

  
  * The Ubuntu magic seems to be not working anymore:
  https://launchpadlibrarian.net/151894146/buildlog_ubuntu-saucy-i386.indicator-sound_12.10.2%2B13.10.20130930-0ubuntu1_UPLOADING.txt.gz

  "Building ${CMAKE_PROJECT_NAME}.pot...
  ...
  None of the files in POTFILES.in contain strings marked for translation.
  dh_langpack: processing files to add translation domain '${CMAKE_PROJECT_NAME}'.."

  dh_translations does that

  "            while (<CMAKELISTSFILE>) {
                  if ( -e 'po/POTFILES.in' ) {
                       $use_intltool = 1;
                  }
                  $domain = $1 if /^set\s*\(GETTEXT_PACKAGE\s*"?([^\s"]*)"?\s*\)/;"

  That doesn't work great with the cmakefilelist having
  "set(GETTEXT_PACKAGE ${CMAKE_PROJECT_NAME})" (e.g it doesn't know to
  escape it)

  
  * There doesn't seem to be a standard makefile target to update the pot? Well at least those don't work
  $ make pot
  $ make translations
  $ make update-pot
  $ make indicator-sound.pot

  
  The result is that currently the list of string handed to translations is not updated as it should :/

To manage notifications about this bug go to:
https://bugs.launchpad.net/indicator-location/+bug/1233679/+subscriptions