dx-packages team mailing list archive

[Charles Kerr <charles.kerr@xxxxxxxxxxxxx>]

** Changed in: indicator-datetime
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to indicator-datetime in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1064546

Title:
  Stray semicolon in datetime-prefs

Status in The Date and Time Indicator:
  Fix Released
Status in “indicator-datetime” package in Ubuntu:
  Fix Released

Bug description:
  Coverity found the stray semicolon in line 311 here in datetime-
  prefs.c:

  311  if (priv->tz_query_cancel == NULL); {
  312    priv->tz_query_cancel = g_cancellable_new();
  313    g_dbus_proxy_call (priv->proxy, "GetTimezone", NULL, G_DBUS_CALL_FLAGS_NONE, -1,
  314                       priv->tz_query_cancel, (GAsyncReadyCallback)tz_query_answered, self);
  315  }
  316}

  Looks like this was introduced in http://bazaar.launchpad.net
  /~indicator-applet-developers/indicator-
  datetime/trunk.12.10/revision/165.1.1 which was added for bug #942450
  for 2012-03-28 ... so this is probably in 12.04 as well.

  It looks to me like the downside of this extra semicolon is that the
  crash in bug #942450 could still be triggered in 12.04 and in
  indicator-datetime 12.10.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/indicator-datetime/+bug/1064546/+subscriptions