dx-packages team mailing list archive

[Launchpad Bug Tracker <1244468@xxxxxxxxxxxxxxxxxx>]

This bug was fixed in the package indicator-sound -
12.10.2+14.04.20131029.1-0ubuntu1

---------------
indicator-sound (12.10.2+14.04.20131029.1-0ubuntu1) trusty; urgency=low

  [ Dmitrijs Ledkovs ]
  * Define "ubiquity" indicator profile, reusing the greeter object. (LP:
    #1241539)

  [ Charles Kerr ]
  * When we can't connect to pulse, wait a moment before retrying. (LP:
    #1244010)
  * In Service's volume_changed() function, explicitly instantiate the
    GVariant to avoid leaking it. See the description in bug #1244468
    for before & after C code and more information. (LP: #1244468)
  * Test that MediaPlayer's icon property isn't NULL before we serialize
    it. (LP: #1229612)

  [ Sebastien Bacher ]
  * Don't special case Unity sessions, that's not needed since gnome-
    control-center is doing the right thing, the session name used was
    also wrong and couldn't work (lp: #1239545). (LP: #1239545)

  [ Lars Uebernickel ]
  * Only display running players in the phone's sound menu The design
    says to only display the _one_ running player. This will have that
    effect, as there's only one player allowed to run at a time on the
    phone.
  * VolumeControl: don't pass vala closures into libpulse Libpulse's
    vala bindings don't specify that callbacks passed into some of its
    functions (e.g., get_server_info) can be called after the function
    returns. Vala thus frees closure data after these functions return.
    This can't easily be fixed in the bindings, because libpulse doesn't
    provide variants of these functions with destroy_notifies. This
    patch works around this problem by only passing non-closure
    functions into libpulse. (LP: #1244386)
  * Depend on vala 0.20 and use its GIcon.serialize().

  [ Ted Gould ]
  * Adding a phone_greeter profile.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 399
 -- Ubuntu daily release <ps-jenkins@xxxxxxxxxxxxxxxxxxx>   Tue, 29 Oct 2013 10:32:48 +0000

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to indicator-sound in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1244468

Title:
  implicitly-generated variants are leaked

Status in Bluetooth Menu:
  Fix Committed
Status in Sound Menu:
  Fix Committed
Status in Vala:
  Fix Released
Status in “indicator-bluetooth” package in Ubuntu:
  Fix Released
Status in “indicator-sound” package in Ubuntu:
  Fix Released

Bug description:
  The implicitly-created GVariant is leaked in Service's
  volume_changed() function. We can fix it by making the variant
  explicit. But, should this be reported upstream as a Vala bug?

  One line diff:
  - volume_action.set_state (volume);
  + volume_action.set_state (new Variant.double (volume));

  C code generated from "volume_action.set_state (volume)":

    static GVariant* _variant_new4 (gdouble value) {
      return g_variant_ref_sink (g_variant_new_double (value));
    }
    static void indicator_sound_service_volume_changed (IndicatorSoundService* self, gdouble volume) {
      ...
      _tmp3_ = volume;
     _tmp4_ = _variant_new4 (_tmp3_);
      g_simple_action_set_state (volume_action, _tmp4_);
      ...
    }

  C code generated from "volume_action.set_state (new Variant.double
  (volume))":

    static void indicator_sound_service_volume_changed (IndicatorSoundService* self, gdouble volume) {
      ...
      _tmp3_ = volume;
      _tmp4_ = g_variant_new_double (_tmp3_);
      g_variant_ref_sink (_tmp4_);
      _tmp5_ = _tmp4_;
      g_simple_action_set_state (volume_action, _tmp5_);
      _g_variant_unref0 (_tmp5_);
      ...
    }

To manage notifications about this bug go to:
https://bugs.launchpad.net/indicator-bluetooth/+bug/1244468/+subscriptions