dx-packages team mailing list archive

[Brandon Schaefer <1079460@xxxxxxxxxxxxxxxxxx>]

Manually testing this now, and show desktop toggles fine for me. Must
have been fixed with the new changes that went into showdesktop. So ill
link that branch as a fix for this.

Im not able to run test_queryshowdesktop.py, but I've a print statement
in ::ShowDesktop(), and it is toggling just fine on an empty desktop.

If you have a list of any failing tests that you still see attributed to
this, let me know!

The branch where the new show desktop stuff landed:
https://code.launchpad.net/~brandontschaefer/unity/show-desktop-fix/+merge/172399

Related bug:
Bug 966030

** Changed in: unity (Ubuntu)
     Assignee: (unassigned) => Brandon Schaefer (brandontschaefer)

** Changed in: unity
     Assignee: (unassigned) => Brandon Schaefer (brandontschaefer)

** Changed in: unity
       Status: Triaged => Fix Committed

** Changed in: unity (Ubuntu)
       Status: Triaged => Fix Committed

** Changed in: unity
       Status: Fix Committed => Fix Released

** Changed in: unity (Ubuntu)
       Status: Fix Committed => Fix Released

** Branch linked: lp:~brandontschaefer/unity/show-desktop-fix

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to unity in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1079460

Title:
  Show Desktop state does not toggle when there are no windows

Status in Ayatana Design:
  Fix Committed
Status in Unity:
  Fix Released
Status in “unity” package in Ubuntu:
  Fix Released

Bug description:
  Super+Ctrl+d (or whatever show desktop is bound to) does not toggle
  the state of PluginAdapter._in_show_desktop when there are no windows
  open. This can be observed with the attached autopilot test,
  test_queryshowdesktop.py.

  [Test Case]
  0. Copy test_queryshowdesktop.py to $unity_source/tests/autopilot/unity/tests/
  1. Open some windows.
  2. from a ssh or other remote login:
  2.a. export DISPLAY=:0.0
  2.b. cd $unity_source/tests/autopilot
  2.c. autopilot run -v unity.tests.test_queryshowdesktop

  Observe - "showdesktop state" should follow with what is stated in the
  test log output.

  3. Close all windows on the unity display.
  4. repeat 2.c.

  Observe - the test will fail because it cannot leave showdesktop mode once it's entered. Note, the showdesktop state is initially 0 meaning disabled, meaning that closing all the windows does not enable showdesktop mode.
  Expected - showdesktop state should continue to toggle with the show desktop key.

  If this is expected behavior, some autopilot tests need some work.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ayatana-design/+bug/1079460/+subscriptions