dx-packages team mailing list archive

[Marco Trevisan (Treviño) <mail@xxxxxxxxx>]

Thanks for the FFe approval, then:

> I'm not sure why you introduced the lock-request signal?

I didn't want to make GSManager (that is a child of GSMonitor) to keep a
reference (even a weak one) of its parent, so the quickest way and the
one that wouldn't have involved too many changes to the GS code, was to
emit a signal that returns a value if the lock is handled.

So, in case unity is running and a lock has been requested, if nothing
fails, unity will handle it and GS will ignore the lock.

> What happens if the lock fails in manager_lock_request? I think you
leak the GSignals too.

If something fails here, the signal will return FALSE, an thus, the
normal GS locking will happen; in case unity will be back (if it has
ever been there), then we replace the g-s locking with the native unity
locking again.

> I think you leak the GSignals too.

You mean the connections?
Btw I've pushed a new version of the patch...

** Patch added: "33_unity_lockscreen_on_lock.patch"
   https://bugs.launchpad.net/unity/+bug/1282798/+attachment/4017110/+files/33_unity_lockscreen_on_lock.patch

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to unity in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1282798

Title:
  [FFe] Provide a lock screen and unlock dialogs in Unity

Status in Unity:
  In Progress
Status in “gnome-screensaver” package in Ubuntu:
  Triaged
Status in “unity” package in Ubuntu:
  Triaged

Bug description:
  [FFe]

  The merge proposal for this work missed the feature freeze dealine by
  a few hours and requires a freeze exception.

  This bug replaces the original FFe file under bug #878836.

  --- original description ---

  We need to provide a thematically compatible lock screen and unlock
  dialogs in Unity, consistent with the unity-greeter authentication
  dialog used in LightDM.  This will replace gnome-screenlocker.

To manage notifications about this bug go to:
https://bugs.launchpad.net/unity/+bug/1282798/+subscriptions