dx-packages team mailing list archive

[Brett Bogert <bbogert24@xxxxxxxxx>]

Khurshid Alam is correct. According to the Unity theming documenation
for Trusty 14.04 the panel text should be set by the UnityPanelWidget as
follows:

UnityPanelWidget,
.unity-panel {
    background-color: shade (@dark_bg_color, 1.5);

    color: @dark_fg_color; /* Text color */   <--- ***SHOULD BE SET HERE***
 }

but it is actually being set by the UnityDecoration "top" code here:

/* This will theme the top decoration, so the whole space above the window */
UnityDecoration.top {
    border: 1px solid shade (@bg_color, 0.5);
    border-bottom-width: 0;
    border-radius: 8px 8px 0 0; /* Corner radius, only the top ones should be */
    padding: 1px 8px 0 8px; /* This padding will be applied to the content of the top layout */
    background-color: shade (@dark_bg_color, 1.5); /* Decoration background */
    color: @dark_fg_color; /* The foreground color will be used to paint the text */  <--- ***ACTUALLY BEING SET HERE ***
    text-shadow: 1px 0 #333, -1px 0 #333, 0 1px #333, 0 -1px #333;
}

This makes it impossible to use a dark panel with light window treatment
as the title color for light window treatment is dark making the panel
label (e.g. "Ubuntu Desktop") and maximized title unreadable on a dark
panel.

In short the panel text color should be set by the unity panel widget
class not by the unity decoration class.

Since this problem is already bug reported I will not open another bug
report but track progress under this bug report number.

Thanks,
B.Bogert

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to unity in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1296866

Title:
  Allow unity-panel.menuitem to paint window title text for maximized
  window in new Unity Decorator(Trusty)

Status in “unity” package in Ubuntu:
  New

Bug description:
  Some themes (Greybird, Elementary) use dark-panel & light window
  title-bar (When it is not maximized). As new Unity window decorator
  uses same title-bar foreground color for both normal & maximized
  windows, window title on unity-panel is not properly visible as it
  becomes dark-text on dark-panel. I have attached a screenshot.

  This forces theme developer to use use same background color for both
  unity-panel & un-maximized windows, which breaks theme design. The
  idea is that theme-developers like to think unity-panel as a panel &
  not just a title-bar for maximized window.

  According to https://wiki.ubuntu.com/Unity/Theming, color set in
  UnityDecoration.top is used for both unmaximized & maximized window.

  UnityDecoration.top {
   color: @dark_fg_color
  }

  And when this is set, the color set in .unity-panel.menuitem is
  ignored for window title text in panel (it still paints some other
  text in panel like indicator-datetime)

  .unity-panel .menuitem {
      border-width: 0 1px;
      color: @panel_fg_color;     # this does not affect window title text anymore. 
  }

  This color (OR unity.panel foreground color in UnityPanelWidget)
  should be used to paint the window tile text for maximized window, as
  it used to be in old compiz-decorator.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1296866/+subscriptions