← Back to team overview

dx-packages team mailing list archive

[Bug 1298656] Re: hud-service crashed with g-assert-if-reached in GMenu call from qtgmenu::QtGMenuModel::CreateChild()

 

** Description changed:

  [Impact]
  
   * Unknown GTK application causes HUD service to crash by sending
  invalid menu updates via GMenu.
  
  [Test Case]
  
   * Not reproducable so far.
  
  [Regression Potential]
  
   * Worst case is that somehow HUD doesn't work on the desktop and phone.
  
-  * There are, obviously, extensive unit and functional tests to verify
+  * There are, obviously, extensive unit and functional tests to verify
  this doesn't happen.
  
  [Other Info]
  
   * The patch will report the offending application to errors.ubuntu.com
  with all available debugging information.
  
   * The indexes are now range checked before processing. As soon as a
  window sends any invalid message it is blocked.
  
-  * Further hardening around the memory management in QtGMenu has been
+  * Further hardening around the memory management in QtGMenu has been
  carried out.
+ 
+ * The change is not as large as it at first appears. The majority of the
+ diff is simply replacing Type* with QSharedPointer<Type>. The rest is
+ the extra code for reporting the recoverable problem.

** Changed in: hud (Ubuntu Trusty)
       Status: New => In Progress

** Changed in: hud (Ubuntu Trusty)
     Assignee: (unassigned) => Pete Woods (pete-woods)

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to hud in Ubuntu.
https://bugs.launchpad.net/bugs/1298656

Title:
  hud-service crashed with g-assert-if-reached in GMenu call from
  qtgmenu::QtGMenuModel::CreateChild()

Status in “hud” package in Ubuntu:
  In Progress
Status in “hud” source package in Trusty:
  In Progress

Bug description:
  [Impact]

   * Unknown GTK application causes HUD service to crash by sending
  invalid menu updates via GMenu.

  [Test Case]

   * Not reproducable so far.

  [Regression Potential]

   * Worst case is that somehow HUD doesn't work on the desktop and
  phone.

   * There are, obviously, extensive unit and functional tests to verify
  this doesn't happen.

  [Other Info]

   * The patch will report the offending application to
  errors.ubuntu.com with all available debugging information.

   * The indexes are now range checked before processing. As soon as a
  window sends any invalid message it is blocked.

   * Further hardening around the memory management in QtGMenu has been
  carried out.

  * The change is not as large as it at first appears. The majority of
  the diff is simply replacing Type* with QSharedPointer<Type>. The rest
  is the extra code for reporting the recoverable problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/hud/+bug/1298656/+subscriptions