dx-packages team mailing list archive

[Christian Dywan <christian@xxxxxxxxxxxx>]

Do we have some code examples? Where do app icons come from? I don't
know how consistent the path is… doing magic on arbitrary path names may
or may not make it even more confusing when the outcome changes
depending on the image.

** Changed in: ubuntu-ui-toolkit (Ubuntu)
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to notify-osd in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1363015

Title:
  App icons require shaping at every callsite

Status in “notify-osd” package in Ubuntu:
  New
Status in “ubuntu-ui-toolkit” package in Ubuntu:
  Incomplete

Bug description:
  In list items, showing an app icon in the correct Ubuntu shape requires shaping it when you are using it: ListItem.Standard{IconFrame: True}.
  <http://developer.ubuntu.com/api/devel/ubuntu-13.04/qml/ui-toolkit/qml-ubuntu-components-listitems0-standard.html>

  That property is set to "True" by default, but it's not obvious why it
  should be, and list items aren't the only place that app icons get
  used.

  The result is that several times now, app updates have ended up without the appropriate frame:
  - in the System Settings "Updates" list (bug 1354478)
  - in the "Notifications" screen
  - in the Launcher the frame is unintentionally different (bug 1332119).

  Conversely, non-app icons have ended up *with* the frame by mistake:
  - "Display language" (bug 1288866)
  - "Orientation Lock" (bug 1365450)
  - Ubuntu updates (bug 1367136).

  In notification bubbles, the opposite applies -- you have to set a hint to use an *unshaped* icon: notify_notification_set_hint_string(m_notification, "x-canonical-non-shaped-icon", "true").
  <https://wiki.ubuntu.com/Touch/Notifications#Elements_of_a_Notification>

  Predictably, this has resulted in cases of icons having frames when they shouldn't:
  - Wi-Fi network authentication (bug 1346904)
  - alarms (bug 1346925)
  - Remove Account (bug 1350282).

  On the API design quality scale, both of these are roughly "Read the
  implementation and you'll get it right." <http://sweng.the-
  davies.net/Home/rustys-api-design-manifesto> Worse, they have opposite
  defaults.

  I suggest that the toolkit move all the way up to "It's impossible to
  get wrong", by always shaping an icon when it is an app icon, and
  never otherwise. Whether an icon is an app icon could (I assume) be
  detected by its path.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/notify-osd/+bug/1363015/+subscriptions