← Back to team overview

dx-packages team mailing list archive

[Bug 1307657] Re: [SRU] UBUNTU_MENUPROXY should not be set in Xfce

 

** Description changed:

+ [Impact]
+ 
+ The upstart script for unity-gtk-module causes it to run under all
+ desktop environments indiscriminately when it should only be running
+ under Unity. It does this by adding unity-gtk-module to the environment
+ variable GTK_MODULES.
+ 
+ In Xfce, this causes the panel to crash when trying to add Unity
+ indicators, as well as other related side effects (see: LP: #1314782,
+ LP: #1347272).
+ 
+ The fix to ensure we only modify GTK_MODULES under Unity is already in
+ 14.10.
+ 
+ [Test Case]
+ 
+ Log into a Xubuntu session on a machine that has both ubuntu-desktop and
+ xubuntu-desktop. Add the Indicator Plugin to the panel and open a
+ terminal window. A crash dialog should appear notifying the user that
+ the Indicator Plugin unexpectedly left the panel.
+ 
+ [Regression Potential]
+ 
+ The potential for regression is low since the only change is to preserve
+ the original value of the GTK_MODULES environment variable, as well as
+ to never set UBUNTU_MENUPROXY. The fix restores the desktop environment
+ to its intended state of not running unity-gtk-module. Also, I've tested
+ the change under Unity, and application menus still work properly under
+ the global menu without regression.
+ 
+ [Other Info]
+ 
+ N/A
+ 
+ === original bug report ===
+ 
  To reproduce: either start with a fresh Ubuntu install and then install
  xubuntu-desktop, or start with Xubuntu and then install ubuntu-desktop -
  ie have both Xfce and Unity installed on the same machine.
  
  Xfce now has support for gtk3 indicators launched by upstart, but
  indicator-appmenu is totally broken - it will constantly crash the panel
  and applications. Xfce has a mechanism to hide indicators, and then the
  frontend UI will not be loaded in the panel, but it seems that
  UBUNTU_MENUPROXY is still being set in Xfce, which causes menus to
  disappear from applications, even though nothing is available to receive
  them.
  
  I discussed this with tedg and he suggested that the problem may be to
  do with the upstart service which sets UBUNTU_MENUPROXY, ie
  /usr/share/upstart/sessions/unity-gtk-module.conf
  
  We may in future get the appmenus working in Xfce, and then we would
  need some way to turn the menuproxy on and off depending on the user
  configuration. But for now, since they are broken anyway, it would be
  easiest to simply blacklist xubuntu desktop completely.
  
  ProblemType: Bug
  DistroRelease: Ubuntu 14.04
  Package: unity-gtk-module-common 0.0.0+14.04.20140403-0ubuntu1
  ProcVersionSignature: Ubuntu 3.13.0-8.28-generic 3.13.2
  Uname: Linux 3.13.0-8-generic x86_64
  NonfreeKernelModules: nvidia
  ApportVersion: 2.14.1-0ubuntu2
  Architecture: amd64
  CurrentDesktop: XFCE
  Date: Mon Apr 14 19:40:36 2014
  InstallationDate: Installed on 2014-02-11 (61 days ago)
  InstallationMedia: Xubuntu 14.04 LTS "Trusty Tahr" - Alpha amd64 (20140210)
  PackageArchitecture: all
  SourcePackage: unity-gtk-module
  UpgradeStatus: No upgrade log present (probably fresh install)

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to unity-gtk-module in Ubuntu.
https://bugs.launchpad.net/bugs/1307657

Title:
  [SRU] UBUNTU_MENUPROXY should not be set in Xfce

Status in “unity-gtk-module” package in Ubuntu:
  Fix Released
Status in “xfce4-indicator-plugin” package in Ubuntu:
  Invalid
Status in “unity-gtk-module” source package in Trusty:
  Confirmed
Status in “xfce4-indicator-plugin” source package in Trusty:
  Confirmed
Status in “unity-gtk-module” source package in Utopic:
  Fix Released
Status in “xfce4-indicator-plugin” source package in Utopic:
  Invalid

Bug description:
  [Impact]

  The upstart script for unity-gtk-module causes it to run under all
  desktop environments indiscriminately when it should only be running
  under Unity. It does this by adding unity-gtk-module to the
  environment variable GTK_MODULES.

  In Xfce, this causes the panel to crash when trying to add Unity
  indicators, as well as other related side effects (see: LP: #1314782,
  LP: #1347272).

  The fix to ensure we only modify GTK_MODULES under Unity is already in
  14.10.

  [Test Case]

  Log into a Xubuntu session on a machine that has both ubuntu-desktop
  and xubuntu-desktop. Add the Indicator Plugin to the panel and open a
  terminal window. A crash dialog should appear notifying the user that
  the Indicator Plugin unexpectedly left the panel.

  [Regression Potential]

  The potential for regression is low since the only change is to
  preserve the original value of the GTK_MODULES environment variable,
  as well as to never set UBUNTU_MENUPROXY. The fix restores the desktop
  environment to its intended state of not running unity-gtk-module.
  Also, I've tested the change under Unity, and application menus still
  work properly under the global menu without regression.

  [Other Info]

  N/A

  === original bug report ===

  To reproduce: either start with a fresh Ubuntu install and then
  install xubuntu-desktop, or start with Xubuntu and then install
  ubuntu-desktop - ie have both Xfce and Unity installed on the same
  machine.

  Xfce now has support for gtk3 indicators launched by upstart, but
  indicator-appmenu is totally broken - it will constantly crash the
  panel and applications. Xfce has a mechanism to hide indicators, and
  then the frontend UI will not be loaded in the panel, but it seems
  that UBUNTU_MENUPROXY is still being set in Xfce, which causes menus
  to disappear from applications, even though nothing is available to
  receive them.

  I discussed this with tedg and he suggested that the problem may be to
  do with the upstart service which sets UBUNTU_MENUPROXY, ie
  /usr/share/upstart/sessions/unity-gtk-module.conf

  We may in future get the appmenus working in Xfce, and then we would
  need some way to turn the menuproxy on and off depending on the user
  configuration. But for now, since they are broken anyway, it would be
  easiest to simply blacklist xubuntu desktop completely.

  ProblemType: Bug
  DistroRelease: Ubuntu 14.04
  Package: unity-gtk-module-common 0.0.0+14.04.20140403-0ubuntu1
  ProcVersionSignature: Ubuntu 3.13.0-8.28-generic 3.13.2
  Uname: Linux 3.13.0-8-generic x86_64
  NonfreeKernelModules: nvidia
  ApportVersion: 2.14.1-0ubuntu2
  Architecture: amd64
  CurrentDesktop: XFCE
  Date: Mon Apr 14 19:40:36 2014
  InstallationDate: Installed on 2014-02-11 (61 days ago)
  InstallationMedia: Xubuntu 14.04 LTS "Trusty Tahr" - Alpha amd64 (20140210)
  PackageArchitecture: all
  SourcePackage: unity-gtk-module
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/unity-gtk-module/+bug/1307657/+subscriptions


References