← Back to team overview

dx-packages team mailing list archive

[Bug 1302955] Re: upstart user session leaks all the dbus events it receives

 

** Changed in: unity/7.2
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to unity in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1302955

Title:
  upstart user session leaks all the dbus events it receives

Status in Unity:
  Fix Released
Status in Unity 7.2 series:
  Fix Committed
Status in unity package in Ubuntu:
  Fix Released
Status in upstart package in Ubuntu:
  Confirmed
Status in unity source package in Trusty:
  Fix Released

Bug description:
  [Impact]

  The unity-panel-service process has been caching D-Bus messages sent
  from upstart, effectively leaking memory.  The solution replaces the
  offending code with a single upstart event emission.

  [Test Case]

  0. Make sure there is a user session job with a dbus rule (eg unity-greeter-session-broadcast)
  1. Install and run system-load-indicator (indicator-multiload)
  2. Set the update interval to 100ms
  3. Now watch the memory use of init --user increase by 100kb per second
  4. Also open up upstart-monitor to see all the dbus messages being sent

  [Regression Potential]

  Some kind of hidden functionality depending on upstart events sent
  through D-Bus to the unity-panel-service may have become disconnected.
  Unlikely.

  [Other Info]

  The fix for Ubuntu 14.04 LTS was cherry picked from the Ubuntu "Vivid
  Vervet" dev release where it has been in regular use for some time
  without apparent regression.

To manage notifications about this bug go to:
https://bugs.launchpad.net/unity/+bug/1302955/+subscriptions