← Back to team overview

dx-packages team mailing list archive

[Bug 1622682] [NEW] incorrect use of 'summary' event property in popup notifications

 

Public bug reported:

As described in RFC 2445:

> When the action is "DISPLAY", the alarm MUST also include a
"DESCRIPTION" property, which contains the text to be displayed when the
alarm is triggered.

The ingest code in engine-eds.cpp is correctly reading the `description'
property to initialize the Alarm struct's 'text' field, but then when it
comes time to display the alarm, it uses Appointment.summary instead.

This appears to be a code leftover from the time before indicator-
datetime added multiple valarm support by separating the Alarm and
Appointment structures.

** Affects: indicator-datetime (Ubuntu)
     Importance: Medium
     Assignee: Charles Kerr (charlesk)
         Status: In Progress

** Changed in: indicator-datetime (Ubuntu)
       Status: New => In Progress

** Changed in: indicator-datetime (Ubuntu)
     Assignee: (unassigned) => Charles Kerr (charlesk)

** Changed in: indicator-datetime (Ubuntu)
   Importance: Undecided => Medium

** Summary changed:

- should use vevent 'description' property in notifications
+ incorrect use of 'summary' event property in popup notifications

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to indicator-datetime in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1622682

Title:
  incorrect use of 'summary' event property in popup notifications

Status in indicator-datetime package in Ubuntu:
  In Progress

Bug description:
  As described in RFC 2445:

  > When the action is "DISPLAY", the alarm MUST also include a
  "DESCRIPTION" property, which contains the text to be displayed when
  the alarm is triggered.

  The ingest code in engine-eds.cpp is correctly reading the
  `description' property to initialize the Alarm struct's 'text' field,
  but then when it comes time to display the alarm, it uses
  Appointment.summary instead.

  This appears to be a code leftover from the time before indicator-
  datetime added multiple valarm support by separating the Alarm and
  Appointment structures.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/indicator-datetime/+bug/1622682/+subscriptions


Follow ups