← Back to team overview

dx-packages team mailing list archive

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

 

> To fix that, something like comment #3 is needed. Such as looping over
all 'active' units that are PartOf graphical-session.target and stopping
them all.

I think we would only need to "systemctl stop graphical-session.target"
for this, otherwise a unit forgets the PartOf= and that loop would not
work anyway.

> gnome-session needs a fix to its ExecStopPost to not kill the one we
just started.

This is similar to waiting for "deactivating" units after
*-session.target goes down. On the systemd sprint we just figured out a
better scheme for this which solves that waiting, does not require this
session ID tracking, and also gets rid of the manual starting of
graphical-session-pre.target: Eventually we just want to declare in
*-session.target that it comes After=graphical-session-pre.target and
have this propagate to the dependencies
(https://github.com/systemd/systemd/issues/3750). Until then we can just
have a mini-generator do this for us. After we have the Requires/After
=graphical-session-pre.target, then "systemctl stop graphical-session-
pre.target" properly blocks until all "later" units are completely
stopped.

** Bug watch added: github.com/systemd/systemd/issues #3750
   https://github.com/systemd/systemd/issues/3750

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to unity-gtk-module in Ubuntu.
https://bugs.launchpad.net/bugs/1618886

Title:
  unity-gtk-module.service is racy; session services don't stop if
  session terminates

Status in gnome-session package in Ubuntu:
  Fix Released
Status in unity-gtk-module package in Ubuntu:
  Fix Released
Status in upstart package in Ubuntu:
  Triaged

Bug description:
  Sometimes on session start unity-gtk-module.service runs too late or
  something, and $GTK_MODULES does not include "unity". It is in
  "systemctl --user show-environment" but not in a terminal bash.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-session/+bug/1618886/+subscriptions


Follow ups

References