← Back to team overview

dx-packages team mailing list archive

[Bug 1629009] Re: Does not work inside a snap due to hardcoded paths

 

This bug was fixed in the package webbrowser-app -
0.23+17.04.20161024.1-0ubuntu1

---------------
webbrowser-app (0.23+17.04.20161024.1-0ubuntu1) zesty; urgency=medium

  [ Andrew Hayzen ]
  * Fix for issue where many tabs causes close button to overlap other
    tabs (LP: #1473630)
  * When page has started, stopped, redirected or errored clear cache for
    history update - which prevents incorrect titles in being set
    (LP: #1603835)
  * Add autopilot tests javascript dialogs to webbrowser and
    webapp-container - alertDialog, beforeUnloadDialog, confirmDialog and
    promptDialog (LP: #1633040)
  * Add user-agent override to display the new twitter mobile interface
    (LP: #1577834)

  [ Florian Boucault ]
  * Improved startup time by 800ms by delaying QML compilation and making
    it asynchronous

  [ Olivier Tilloy ]
  * Replace chromium version in UA overrides at runtime, not at build
    time (LP: #1599695)
  * Initial support for generating a snap package for webbrowser-app
    (LP: #1629009)
  * Do not persist references to incognito downloads on disk
    (LP: #1625519)
  * Increase test coverage (to 97.5%) for DownloadsModel (LP: #1534102)
  * Various performance optimizations linked to load events
    (LP: #1611680)
  * Ensure a tab is loaded when re-opened (LP: #1632246)
  * Fix drag'n'drop of bookmarks within the new tab view (LP: #1584868)
  * Work around a limitation in the sound and microphone policy groups
    to "fix" sound in yakkety an zesty (LP: #1632620)

 -- Olivier Tilloy <olivier.tilloy@xxxxxxxxxxxxx>  Mon, 24 Oct 2016
13:51:59 +0000

** Changed in: webbrowser-app (Ubuntu)
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to indicator-transfer in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1629009

Title:
  Does not work inside a snap due to hardcoded paths

Status in Ubuntu File Manager App:
  Fix Committed
Status in address-book-app package in Ubuntu:
  Fix Committed
Status in dialer-app package in Ubuntu:
  New
Status in history-service package in Ubuntu:
  New
Status in indicator-bluetooth package in Ubuntu:
  New
Status in indicator-keyboard package in Ubuntu:
  New
Status in indicator-location package in Ubuntu:
  New
Status in indicator-messages package in Ubuntu:
  New
Status in indicator-network package in Ubuntu:
  New
Status in indicator-power package in Ubuntu:
  New
Status in indicator-session package in Ubuntu:
  New
Status in indicator-sound package in Ubuntu:
  New
Status in indicator-transfer package in Ubuntu:
  New
Status in messaging-app package in Ubuntu:
  New
Status in ubuntu-system-settings package in Ubuntu:
  Fix Committed
Status in ubuntu-terminal-app package in Ubuntu:
  New
Status in ubuntu-touch-session package in Ubuntu:
  New
Status in unity-scope-scopes package in Ubuntu:
  New
Status in unity-scopes-api package in Ubuntu:
  In Progress
Status in unity-scopes-shell package in Ubuntu:
  In Progress
Status in unity8 package in Ubuntu:
  Fix Released
Status in webbrowser-app package in Ubuntu:
  Fix Released

Bug description:
  Some apps can't find their main qml file.  Error messages like:

  "file:///build/messaging-app-gcXPE6/messaging-
  app-0.1+16.04.20160831/src/qml/messaging-app.qml: File not found"

  (in my case, the file was in /snap/unity8-session/x24/usr/share
  /messaging-app/messaging-app.qml)

  Seems due to code like the following in config.h.in.  Probably needs
  to consider the value of $SNAP or just be a little more forgiving.

  inline bool isRunningInstalled() {
      static bool installed = (QCoreApplication::applicationDirPath() ==
                               QDir(("@CMAKE_INSTALL_PREFIX@/@CMAKE_INSTALL_BINDIR@")).canonicalPath());
      return installed;
  }

  inline QString messagingAppDirectory() {
      if (isRunningInstalled()) {
          return QString("@CMAKE_INSTALL_PREFIX@/@MESSAGING_APP_DIR@/");
      } else {
          return QString("@CMAKE_SOURCE_DIR@/src/qml/");
      }
  }

  inline QString ubuntuPhonePluginPath() {
      if (isRunningInstalled()) {
          return QString::null;
      } else {
          return QString("@CMAKE_SOURCE_DIR@/");
      }
  }

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1629009/+subscriptions