← Back to team overview

dx-packages team mailing list archive

[Bug 1443052] Re: User accounts login history showing incorrect history - patch

 

I have tested the packages from -proposed on both Trusty and Xenial and
I can confirm that they both solve the problem with no currently
noticeable regressions.

The package versions I tested were:

- Xenial: 0.6.40-2ubuntu11.3
- Trusty: 0.6.35-0ubuntu7.3

I tested the Xenial one in an Ubuntu GNOME 16.04.1 (GNOME 3.18) 64-bit
VM, and I tested the Trusty one in an Ubuntu (Unity) 14.04.5 64-bit VM.

** Tags removed: verification-needed
** Tags added: verification-done

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to accountsservice in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1443052

Title:
  User accounts login history showing incorrect history - patch

Status in accountsservice:
  Unknown
Status in gnome-control-center:
  Unknown
Status in Ubuntu GNOME:
  Triaged
Status in accountsservice package in Ubuntu:
  Fix Released
Status in accountsservice source package in Trusty:
  Fix Committed
Status in accountsservice source package in Xenial:
  Fix Committed

Bug description:
  Impact
  -------

  Logout times for users are correct if user logs off and then shutdown
  from GDM, however logout times are wrong if user shutdowns directly
  from the user session, because DEAD_PROCESS record is missing in that
  case and BOOT_TIME record is used instead.

  Therefore the logout time will be shown in the login-history (in the
  gnome-control-center) just before the next login time rather than when
  the logout actually occurred.

  Test case
  ----------

  1. Make sure that you have turned on and logged into the machine and
  then turned off from the user session several times with enough
  distance between them for you to tell that the timestamps are correct.

  2. Check that after applying the patch that the timestamps show the
  correct times for the logins and logouts and not what is described in
  the Impact section above.

  Regression potential
  --------------------

  I have not encountered any regressions while testing this patch.
  [bdmurray] - What could go wrong? What should a user testing this look for?

  ----------------------

  Original description:

  I have found that in "System Settings > User Accounts" that if you
  select an account and then select the button called "History" (which
  is meant to show the login history for that account), it will show you
  when you last logged in as "Session Started", but it will show that
  you "Session Ended" just before you login the next time.

  To clarify what I mean, let's say that yesterday I logged into my
  account on this machine at 14:29, and then sometime near 23:00 I
  logged out, and then this morning I logged into my account somewhere
  around 11:20, it will show this:

          Today 11:20 Session Started
          Today 11:19 Session Ended
          Yesterday, 14:29 Session Started

  So it assumes that the last session ended when you log into a new one,
  so the bug seems to be that it does not log when a session ends
  properly, and only logs it when a new session starts.

  I have attached a screenshot to show my example as I see it in the
  History GUI.

  I have found this bug to be present in Ubuntu 14.04, Ubuntu 15.04,
  Ubuntu GNOME 15.10 with GNOME 3.18, and Ubuntu GNOME 16.04 with GNOME
  3.20.

To manage notifications about this bug go to:
https://bugs.launchpad.net/accountsservice/+bug/1443052/+subscriptions