dx-packages team mailing list archive

[David Jordan <dmj726@xxxxxxxxxxxxx>]

** Description changed:

- STEPS:
- 1. grab the latest iso
- 2. Note the header during install
+ [Impact]
  
- EXPECTED:
- Icon on one header
+ During install and oem-firstboot, the header bar at the top of the
+ screen in Ubiquity is twice as tall as it should be on hidpi screens
+ (looking like two normal sized header bars stacked on top of each
+ other), and the blue a11y icon is double sized.
  
- ACTUAL:
- I believe the a11y icon is double sized and forces a double header.  see photo
+ This looks obviously incorrect and ugly and makes a bad first impression
+ on users installing Ubuntu on a hidpi laptop or customers of Ubuntu OEMs
+ booting new machines for the first time.  Arstechnica commented
+ negatively on this in their review of Dell's XPS 13:
+ http://arstechnica.com/gadgets/2017/01/dells-latest-xps-13-de-still-
+ delivers-linux-now-embraces-svelte-hardware/
  
- /!\ Seem to be a hidpi only issue I see it on xps13 but not on other
- installs
+ Users of the Dell XPS 13 are affected as well as users of other brands
+ of laptops with hidpi screens.  System76 is temporarily carrying a
+ patched version of Humanity to work around this bug.
+ 
+ The a11y icon is double-sized because the version of Humanity shipping
+ in Ubuntu doesn't support @2 hidpi scaling, which results in the header
+ bar doubling its height.  Because the header bar is drawn with
+ CAIRO_PAD_REPEAT, the gradient is repeated so it looks like two bars
+ stacked one on top of the other.  The fix to the Humanity icon theme
+ adds @2 hidpi support, which shrinks the icon and restores the header
+ bar to its normal height.
+ 
+ 
+ [Test Case]
+ ISO install:
+ 1. Grab an Ubuntu iso and proceed to install (not "try") Ubuntu on a computer with a hidpi screen.
+ 2. Note the double-sized header and icon during install.
+     - Using an iso with a fixed version of Humanity, the header and icon should look normal.
+ 
+ OEM-Firstboot:
+ 1. Grab an Ubuntu iso and do an oem-install on on a computer with a hidpi screen.
+ 2. After installing, click the launcher icon to "Prepare for shipping to the end user" and reboot.
+ 3. During oem-firstboot, note the double-sized header and icon during install.
+     - To test the fix, install a fixed version of humanity before preparing the system for the end user.
+     
+ 
+ [Regression Potential]
+ 
+ This patch affects the look of anything using the Humanity icon set.
+ The look of Nautilus, and many other GTK apps will be affected.  This is
+ not a regression but fixes another bug and resolves a discrepancy
+ between rendering of icons on hidpi screens vs lowdpi screens.
+ 
+ The biggest risk for regression comes from the off chance that there is
+ an error or omission in the index.theme files.  Comparing icons on a
+ broad range of applications and systems should catch this class of
+ issues.  If any issues with icons are found, check there.

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to humanity-icon-theme in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1622686

Title:
  double header in 16.10

Status in humanity-icon-theme package in Ubuntu:
  Fix Released
Status in ubiquity package in Ubuntu:
  Fix Released
Status in humanity-icon-theme source package in Xenial:
  New
Status in ubiquity source package in Xenial:
  New
Status in humanity-icon-theme source package in Yakkety:
  New
Status in ubiquity source package in Yakkety:
  New

Bug description:
  [Impact]

  During install and oem-firstboot, the header bar at the top of the
  screen in Ubiquity is twice as tall as it should be on hidpi screens
  (looking like two normal sized header bars stacked on top of each
  other), and the blue a11y icon is double sized.

  This looks obviously incorrect and ugly and makes a bad first
  impression on users installing Ubuntu on a hidpi laptop or customers
  of Ubuntu OEMs booting new machines for the first time.  Arstechnica
  commented negatively on this in their review of Dell's XPS 13:
  http://arstechnica.com/gadgets/2017/01/dells-latest-xps-13-de-still-
  delivers-linux-now-embraces-svelte-hardware/

  Users of the Dell XPS 13 are affected as well as users of other brands
  of laptops with hidpi screens.  System76 is temporarily carrying a
  patched version of Humanity to work around this bug.

  The a11y icon is double-sized because the version of Humanity shipping
  in Ubuntu doesn't support @2 hidpi scaling, which results in the
  header bar doubling its height.  Because the header bar is drawn with
  CAIRO_PAD_REPEAT, the gradient is repeated so it looks like two bars
  stacked one on top of the other.  The fix to the Humanity icon theme
  adds @2 hidpi support, which shrinks the icon and restores the header
  bar to its normal height.

  
  [Test Case]
  ISO install:
  1. Grab an Ubuntu iso and proceed to install (not "try") Ubuntu on a computer with a hidpi screen.
  2. Note the double-sized header and icon during install.
      - Using an iso with a fixed version of Humanity, the header and icon should look normal.

  OEM-Firstboot:
  1. Grab an Ubuntu iso and do an oem-install on on a computer with a hidpi screen.
  2. After installing, click the launcher icon to "Prepare for shipping to the end user" and reboot.
  3. During oem-firstboot, note the double-sized header and icon during install.
      - To test the fix, install a fixed version of humanity before preparing the system for the end user.
      

  [Regression Potential]

  This patch affects the look of anything using the Humanity icon set.
  The look of Nautilus, and many other GTK apps will be affected.  This
  is not a regression but fixes another bug and resolves a discrepancy
  between rendering of icons on hidpi screens vs lowdpi screens.

  The biggest risk for regression comes from the off chance that there
  is an error or omission in the index.theme files.  Comparing icons on
  a broad range of applications and systems should catch this class of
  issues.  If any issues with icons are found, check there.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/humanity-icon-theme/+bug/1622686/+subscriptions