dx-packages team mailing list archive

[Michael Gratton <mike@xxxxxxx>]

Public bug reported:

Vala 0.31.1 deprecated the "Deprecated" code attribute, replacing it
with "Version". The copy of unity.vapi shipped by libunity-dev in bionic
still uses the Deprecated attribute, however.

I.e. in unity.vapi:

    [Deprecated (replacement = "AppInfoManager.get_default")]
    public static Unity.AppInfoManager get_instance ();

Should instead be:

    [Version (deprecated = true, replacement = "AppInfoManager.get_default")]
    public static Unity.AppInfoManager get_instance ();

This causes a deprecation warning when compiling against it, regardless
of whether any deprecated calls are actually being made by the code
being compiled. While a minor issue, it would be good to have fixed
since it makes it impossible to develop against it with fatal warnings
enabled, which is bad for QA.

The Unity build seems to generate that file as per usual (as a valac
build artefact) so I would assume this should be fixed by a simple
rebuild using vala >= 0.31.1, but surely the version of libunity-dev
that shipped with bionic would have been rebuild against valac that
ships with bionic (0.40)? So I'm not sure why Deprecated is still
present in the vapi.

ProblemType: Bug
DistroRelease: Ubuntu 18.04
Package: libunity-dev 7.1.4+18.04.20180209.1-0ubuntu2
ProcVersionSignature: Ubuntu 4.15.0-20.21-generic 4.15.17
Uname: Linux 4.15.0-20-generic x86_64
ApportVersion: 2.20.9-0ubuntu7
Architecture: amd64
CurrentDesktop: GNOME
Date: Mon May 21 10:45:08 2018
InstallationDate: Installed on 2015-07-22 (1033 days ago)
InstallationMedia: Ubuntu-GNOME 15.04 "Vivid Vervet" - Release amd64 (20150422)
SourcePackage: libunity
UpgradeStatus: No upgrade log present (probably fresh install)

** Affects: libunity (Ubuntu)
     Importance: Undecided
         Status: New


** Tags: amd64 apport-bug bionic wayland-session

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to libunity in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1772338

Title:
  Deprecation warning compiling against unity.vapi

Status in libunity package in Ubuntu:
  New

Bug description:
  Vala 0.31.1 deprecated the "Deprecated" code attribute, replacing it
  with "Version". The copy of unity.vapi shipped by libunity-dev in
  bionic still uses the Deprecated attribute, however.

  I.e. in unity.vapi:

      [Deprecated (replacement = "AppInfoManager.get_default")]
      public static Unity.AppInfoManager get_instance ();

  Should instead be:

      [Version (deprecated = true, replacement = "AppInfoManager.get_default")]
      public static Unity.AppInfoManager get_instance ();

  This causes a deprecation warning when compiling against it,
  regardless of whether any deprecated calls are actually being made by
  the code being compiled. While a minor issue, it would be good to have
  fixed since it makes it impossible to develop against it with fatal
  warnings enabled, which is bad for QA.

  The Unity build seems to generate that file as per usual (as a valac
  build artefact) so I would assume this should be fixed by a simple
  rebuild using vala >= 0.31.1, but surely the version of libunity-dev
  that shipped with bionic would have been rebuild against valac that
  ships with bionic (0.40)? So I'm not sure why Deprecated is still
  present in the vapi.

  ProblemType: Bug
  DistroRelease: Ubuntu 18.04
  Package: libunity-dev 7.1.4+18.04.20180209.1-0ubuntu2
  ProcVersionSignature: Ubuntu 4.15.0-20.21-generic 4.15.17
  Uname: Linux 4.15.0-20-generic x86_64
  ApportVersion: 2.20.9-0ubuntu7
  Architecture: amd64
  CurrentDesktop: GNOME
  Date: Mon May 21 10:45:08 2018
  InstallationDate: Installed on 2015-07-22 (1033 days ago)
  InstallationMedia: Ubuntu-GNOME 15.04 "Vivid Vervet" - Release amd64 (20150422)
  SourcePackage: libunity
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libunity/+bug/1772338/+subscriptions