dx-packages team mailing list archive

[Robie Basak <1898477@xxxxxxxxxxxxxxxxxx>]

Hello Sebastian, or anyone else affected,

Accepted indicator-applet into focal-proposed. The package will build
now and be available at https://launchpad.net/ubuntu/+source/indicator-
applet/12.10.2+20.04.20201004-0ubuntu1 in a few hours, and then in the
-proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
focal to verification-done-focal. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-focal. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Description changed:

  [Impact]
  
  In Focal the indicator-applet (12.10.2+20.04.20200409-0ubuntu1) contains
  a bug that can cause duplicate icons to appear in the applet. When an
  application which creates a notification item is closed, then the
  indicator applet will just hide its item and not remove it. If the
  application is started again, a new item will be added to the applet,
  but the old item is still present (just hidden). When the panel is moved
  or otherwise refreshed, then all items will be made visible again,
  causing many duplicates.
  
  The required fix is included in https://bazaar.launchpad.net/~indicator-
  applet-developers/indicator-applet/trunk.14.04/revision/451 and needs to
  be back ported into the new SRU release.
  
  For more details see this merge request:
  https://code.launchpad.net/~lanoxx/indicator-applet/fix-duplicate-icons/+merge/390344
  
  [Test Case]
  
-  1. Open an application which adds a notification item to the indicator applet. Examples for such an applications are VLC, Network Manager Applet, or Skype.
-  2. Close the application and reopen it.
-  3. Hold Alt key, then move the panel which has the indicator applet to an different edge of the screen.
-  4. Observe that new two icons of the respective application are visible (e.g. to VLC icons).
+  1. Open an application which adds a notification item to the indicator applet. Examples for such an applications are VLC, Network Manager Applet, or Skype.
+  2. Close the application and reopen it.
+  3. Hold Alt key, then move the panel which has the indicator applet to an different edge of the screen.
+  4. Observe that new two icons of the respective application are visible (e.g. to VLC icons).
  
  [Regression Potential]
  
-  * The regression potential is minimal. The only user of this package are the GNOME Flashback packages. The biggest impact this change could have is that indicator applet items behave incorrectly, which is not worse than the current situation.
-  * I have tested this patch for several weeks now and not found any regressions.
+  * The regression potential is minimal. The only user of this package are the GNOME Flashback packages. The biggest impact this change could have is that indicator applet items behave incorrectly, which is not worse than the current situation.
+  * I have tested this patch for several weeks now and not found any regressions.
+ 
+ [racb] The code path being changed is when indicator items are removed.
+ Regressions may manifest if this code path is exercised in some
+ unexpected way.

** Description changed:

  [Impact]
  
  In Focal the indicator-applet (12.10.2+20.04.20200409-0ubuntu1) contains
  a bug that can cause duplicate icons to appear in the applet. When an
  application which creates a notification item is closed, then the
  indicator applet will just hide its item and not remove it. If the
  application is started again, a new item will be added to the applet,
  but the old item is still present (just hidden). When the panel is moved
  or otherwise refreshed, then all items will be made visible again,
  causing many duplicates.
  
  The required fix is included in https://bazaar.launchpad.net/~indicator-
  applet-developers/indicator-applet/trunk.14.04/revision/451 and needs to
  be back ported into the new SRU release.
  
  For more details see this merge request:
  https://code.launchpad.net/~lanoxx/indicator-applet/fix-duplicate-icons/+merge/390344
  
  [Test Case]
  
   1. Open an application which adds a notification item to the indicator applet. Examples for such an applications are VLC, Network Manager Applet, or Skype.
   2. Close the application and reopen it.
   3. Hold Alt key, then move the panel which has the indicator applet to an different edge of the screen.
   4. Observe that new two icons of the respective application are visible (e.g. to VLC icons).
  
  [Regression Potential]
  
   * The regression potential is minimal. The only user of this package are the GNOME Flashback packages. The biggest impact this change could have is that indicator applet items behave incorrectly, which is not worse than the current situation.
   * I have tested this patch for several weeks now and not found any regressions.
  
- [racb] The code path being changed is when indicator items are removed.
- Regressions may manifest if this code path is exercised in some
- unexpected way.
+ [racb] The code path being changed is the signal handler that fires when
+ indicator items are removed. Regressions may manifest if this code path
+ is exercised in some unexpected way.

** Changed in: indicator-applet (Ubuntu Focal)
       Status: New => Fix Committed

** Tags added: verification-needed verification-needed-focal

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to indicator-applet in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1898477

Title:
  Old indicator items are not removed, just hidden

Status in indicator-applet package in Ubuntu:
  Fix Released
Status in indicator-applet source package in Focal:
  Fix Committed

Bug description:
  [Impact]

  In Focal the indicator-applet (12.10.2+20.04.20200409-0ubuntu1)
  contains a bug that can cause duplicate icons to appear in the applet.
  When an application which creates a notification item is closed, then
  the indicator applet will just hide its item and not remove it. If the
  application is started again, a new item will be added to the applet,
  but the old item is still present (just hidden). When the panel is
  moved or otherwise refreshed, then all items will be made visible
  again, causing many duplicates.

  The required fix is included in https://bazaar.launchpad.net
  /~indicator-applet-developers/indicator-
  applet/trunk.14.04/revision/451 and needs to be back ported into the
  new SRU release.

  For more details see this merge request:
  https://code.launchpad.net/~lanoxx/indicator-applet/fix-duplicate-icons/+merge/390344

  [Test Case]

   1. Open an application which adds a notification item to the indicator applet. Examples for such an applications are VLC, Network Manager Applet, or Skype.
   2. Close the application and reopen it.
   3. Hold Alt key, then move the panel which has the indicator applet to an different edge of the screen.
   4. Observe that new two icons of the respective application are visible (e.g. to VLC icons).

  [Regression Potential]

   * The regression potential is minimal. The only user of this package are the GNOME Flashback packages. The biggest impact this change could have is that indicator applet items behave incorrectly, which is not worse than the current situation.
   * I have tested this patch for several weeks now and not found any regressions.

  [racb] The code path being changed is the signal handler that fires
  when indicator items are removed. Regressions may manifest if this
  code path is exercised in some unexpected way.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/indicator-applet/+bug/1898477/+subscriptions