← Back to team overview

dx-packages team mailing list archive

[Bug 1898477] Re: Old indicator items are not removed, just hidden

 

Hey Dmitry! You mentioned indicator-appmenu on Ubuntu groovy, even
though the SRU is targeting focal. Did you mean to say that the same fix
is also present in groovy and that there it seems to be causing invalid
behavior?

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to indicator-applet in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1898477

Title:
  Old indicator items are not removed, just hidden

Status in indicator-applet package in Ubuntu:
  Fix Released
Status in indicator-applet source package in Focal:
  Fix Committed

Bug description:
  [Impact]

  In Focal the indicator-applet (12.10.2+20.04.20200409-0ubuntu1)
  contains a bug that can cause duplicate icons to appear in the applet.
  When an application which creates a notification item is closed, then
  the indicator applet will just hide its item and not remove it. If the
  application is started again, a new item will be added to the applet,
  but the old item is still present (just hidden). When the panel is
  moved or otherwise refreshed, then all items will be made visible
  again, causing many duplicates.

  The required fix is included in https://bazaar.launchpad.net
  /~indicator-applet-developers/indicator-
  applet/trunk.14.04/revision/451 and needs to be back ported into the
  new SRU release.

  For more details see this merge request:
  https://code.launchpad.net/~lanoxx/indicator-applet/fix-duplicate-icons/+merge/390344

  [Test Case]

   1. Open an application which adds a notification item to the indicator applet. Examples for such an applications are VLC, Network Manager Applet, or Skype.
   2. Close the application and reopen it.
   3. Hold Alt key, then move the panel which has the indicator applet to an different edge of the screen.
   4. Observe that new two icons of the respective application are visible (e.g. to VLC icons).

  [Regression Potential]

   * The regression potential is minimal. The only user of this package are the GNOME Flashback packages. The biggest impact this change could have is that indicator applet items behave incorrectly, which is not worse than the current situation.
   * I have tested this patch for several weeks now and not found any regressions.

  [racb] The code path being changed is the signal handler that fires
  when indicator items are removed. Regressions may manifest if this
  code path is exercised in some unexpected way.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/indicator-applet/+bug/1898477/+subscriptions


References