ecryptfs-devel team mailing list archive

[Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>]

(cc's added)

On Tue, 6 Jan 2009 17:57:44 -0500
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> On Mon, Jan 05, 2009 at 12:43:00AM -0800, Andrew Morton wrote:
> 
> > ecryptfs-filename-encryption-tag-70-packets.patch
> > ecryptfs-filename-encryption-header-updates.patch
> > ecryptfs-filename-encryption-encoding-and-encryption-functions.patch
> > ecryptfs-filename-encryption-filldir-lookup-and-readlink.patch
> > ecryptfs-filename-encryption-mount-option.patch
> > ecryptfs-replace-%z-with-%z.patch
> > ecryptfs-fix-data-types-int-size_t.patch
> > ecryptfs-kerneldoc-for-ecryptfs_parse_tag_70_packet.patch
> > ecryptfs-clean-up-ecryptfs_decode_from_filename.patch
> > fs-ecryptfs-inodec-cleanup-kerneldoc.patch
> 
> By using lookup_one_len on an arbitrary underlying filesystem this
> breaks the assumption that a nameidata is always available.  Please
> redo to use proper lookup helpers.

It that a nack, or do we think we can address this in the next week or
three?

>  Also whole code feels rather
> fragile from a 10000 feet view, but beeing plsit in so many
> patches it's almost impossible to properly review it anywya.
> 

Yes, it made my brain hurt.