← Back to team overview

ecryptfs-devel team mailing list archive

Re: [PATCH] ecryptfs-setup-private should restore the context of Private.{mnt, sig}

 

On Wed, Mar 2, 2011 at 5:38 AM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
> Private.mnt and Private.sig are created initially via mktemp and then
> moved to their destination.  This leaves them with a home_tmp_t context.
>
> This patch fixes it.
>
> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>

Thanks, applied.

Committed revision 529.  This will be in the next release
(ecryptfs-utils-87), with a minor change (looking for the restorecon
tool before running restorecon, so that this will continue working on
systems that do not use selinux).

Cheers,
Dustin

> ---
> ecryptfs-setup-private |    2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/utils/ecryptfs-setup-private
> b/src/utils/ecryptfs-setup-private
> --- a/src/utils/ecryptfs-setup-private  2011-03-02 12:22:05.000000000 +0100
> +++ b/src/utils/ecryptfs-setup-private  2011-03-02 12:22:47.000000000 +0100
> @@ -399,9 +399,11 @@
> temp=`mktemp`
> echo "$sig" > "$temp" || error "$(gettext 'Could not create signature
> file')" "[$HOME/.ecryptfs/$PRIVATE_DIR.sig]"
> mv "$temp" "$HOME/.ecryptfs/$PRIVATE_DIR.sig"
> +restorecon "$HOME/.ecryptfs/$PRIVATE_DIR.sig" > /dev/null 2>&1
> temp=`mktemp`
> echo "$MOUNTPOINT" > "$temp" || error "$(gettext 'Could not create
> mountpoint file')" "[$HOME/.ecryptfs/$PRIVATE_DIR.mnt]"
> mv "$temp" "$HOME/.ecryptfs/$PRIVATE_DIR.mnt"
> +restorecon "$HOME/.ecryptfs/$PRIVATE_DIR.mnt" > /dev/null 2>&1
>
> echo
> echo "$(gettext 'Done configuring.')"
>



-- 
:-Dustin

Dustin Kirkland
Ubuntu Server, Core Developer
Canonical, LTD