edubuntu-bugs team mailing list archive

[Vagrant Cascadian <1021579@xxxxxxxxxxxxxxxxxx>]

On 2014-08-13, Vagrant Cascadian wrote:
> Tested your patches, and with slight modifications, committed upstream:
>
>   https://bazaar.launchpad.net/~ltsp-upstream/ltsp/ltspfs-trunk/revision/170

These patches, while they appear to work, generate some build warnings:

Making all in src
make[3]: Entering directory '/«PKGBUILDDIR»/src'
gcc -DHAVE_CONFIG_H -I. -I..   -D_FORTIFY_SOURCE=2 -Wall -W
-D_FILE_OFFSET_BITS=64 -DFUSE_USE_VERSION=22 -D_REENTRANT -g -O2
-fstack-protector-strong -
Wformat -Werror=format-security -c -o ltspfs-ltspfs.o `test -f
'ltspfs.c' || echo './'`ltspfs.c
ltspfs.c: In function 'ltspfs_statfs':
ltspfs.c:891:9: warning: unused variable 'f_namelen' [-Wunused-variable]
     int f_namelen = (int)stbuf->f_namelen;
         ^
ltspfs.c:890:9: warning: unused variable 'f_bsize' [-Wunused-variable]
     int f_bsize = (int)stbuf->f_bsize;
         ^
ltspfs.c:889:9: warning: unused variable 'f_type' [-Wunused-variable]
     int f_type = (int)stbuf->f_type;
         ^
...

gcc -DHAVE_CONFIG_H -I. -I..   -D_FORTIFY_SOURCE=2 -Wall -W
-D_FILE_OFFSET_BITS=64 -DAUTOMOUNT -D_REENTRANT -g -O2
-fstack-protector-strong -Wformat -Werror=format-security -c -o
ltspfsd-ltspfsd_functions.o `test -f 'ltspfsd_functions.c' || echo './'`ltspfsd_functions.c
ltspfsd_functions.c: In function 'ltspfs_statfs':
ltspfsd_functions.c:906:18: warning: 'f_type' may be used uninitialized
in this function [-Wmaybe-uninitialized]
     stbuf.f_type = (__SWORD_TYPE) f_type;
                  ^
ltspfsd_functions.c:907:19: warning: 'f_bsize' may be used uninitialized
in this function [-Wmaybe-uninitialized]
     stbuf.f_bsize = (__SWORD_TYPE) f_bsize;
                   ^

These patches seem to need little more touch-up...


They also seem to partially revert changes introduced in:

  https://bazaar.launchpad.net/~ltsp-upstream/ltsp/ltspfs-
trunk/revision/153


Maybe the size reporting issues go back that far...


live well,
  vagrant

-- 
You received this bug notification because you are a member of Edubuntu
Bugsquad, which is subscribed to ltspfs in Ubuntu.
https://bugs.launchpad.net/bugs/1021579

Title:
  ltspfs shows wrong partition size when plug-in usb drive into thin
  client

To manage notifications about this bug go to:
https://bugs.launchpad.net/ltsp/+bug/1021579/+subscriptions