edubuntu-bugs team mailing list archive

[Steve Langasek <steve.langasek@xxxxxxxxxxxxx>]

I might suggest future-proofing some of the lintian overrides, so that
they don't need to be updated every time the version of the component
(and thus the filesystem path) changes.

There are also these lintian warnings on the binary package, looks like
you didn't update debian/moodle.lintian-overrides, only the sourceful
one:

W: moodle: embedded-javascript-library usr/share/moodle/lib/editor/tinymce/tiny_mce/3.5.11/tiny_mce.js please use tinymce
W: moodle: embedded-javascript-library usr/share/moodle/lib/editor/tinymce/tiny_mce/3.5.11/tiny_mce_popup.js please use tinymce
W: moodle: embedded-javascript-library usr/share/moodle/lib/editor/tinymce/tiny_mce/3.5.11/tiny_mce_src.js please use tinymce
W: moodle: extra-license-file usr/share/moodle/lib/htmlpurifier/LICENSE
W: moodle: embedded-javascript-library usr/share/moodle/lib/jquery/ui-1.11.4/external/jquery/jquery.js please use libjs-jquery
W: moodle: extra-license-file usr/share/moodle/lib/lessphp/LICENSE
W: moodle: extra-license-file usr/share/moodle/lib/mustache/LICENSE
W: moodle: extra-license-file usr/share/moodle/lib/requirejs/LICENSE
W: moodle: embedded-javascript-library usr/share/moodle/lib/yuilib/3.17.2/yui/yui-min.js please use libjs-yui
W: moodle: extra-license-file usr/share/moodle/mod/assign/feedback/editpdf/fpdi/LICENSE
E: moodle: php-script-but-no-phpX-cli-dep usr/share/moodle/admin/mailout-debugger.php
E: moodle: php-script-but-no-phpX-cli-dep usr/share/moodle/admin/process_email.php
N: 2 tags overridden (2 warnings)

Attached is a patch to fix the majority of these, except two:

 - The php-script-but-no-phpX-cli-dep is a bug in lintian, the long description of the lintian error says as much.  Should be fixed there instead of here.
 - Although the previous version of moodle already bundled jquery, lintian did not report on it.  Rather than assuming this bundling is correct and appropriate and overriding the warning, I'm leaving the warning unmasked.  It's possible that with the current version of libjs-jquery available in Ubuntu, linking might be more appropriate than bundling.  There's no requirement to address this before release because it's not a regression, but let's not make the issue harder to spot.

With these changes, the package looks good to me, so sponsoring.

** Patch added: "moodle-moar-fixes.diff"
   https://bugs.launchpad.net/ubuntu/+source/moodle/+bug/1562172/+attachment/4620182/+files/moodle-moar-fixes.diff

-- 
You received this bug notification because you are a member of Edubuntu
Bugsquad, which is subscribed to moodle in Ubuntu.
https://bugs.launchpad.net/bugs/1562172

Title:
  [FFe] Update to moodle 3.0.3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/moodle/+bug/1562172/+subscriptions