elementary-dev-community team mailing list archive

Thread
Date

Re: [Merge] lp:~darcy-develin/pantheon-terminal/fix-1047106 into lp:pantheon-terminal

To: elementary-dev-community@xxxxxxxxxxxxxxxxxxx
From: Darcy Brás da Silva <dardevelin@xxxxxxxxxxxxxx>
Date: Fri, 07 Sep 2012 21:03:55 +0100
In-reply-to: <20120907154339.13889.35233.codereview@soybean.canonical.com>

Regarding that problem I just followed what was there. HBox wasn't using
Gtk. prefix and the code does include a "using Gtk" at the top. so in
others words. The problems with this CGL(Coding Guide lines) 
come from the example given by the project itself.
I should also take the moment to say that until the CGL is made publicly
available in the elementary website, it shouldn't be enforced. People
are not wizards that guess them.
None the less , it's fixed now... And I already proposed a merge.
It's up to you ...
On Fri, 2012-09-07 at 15:44 +0000, Victor Eduardo wrote:
> The coding style guidelines also suggest using "Gtk.Box" instead of simply "Box". The "using" keyword should be avoided.

-- 
Darcy Brás da Silva <dardevelin@xxxxxxxxxxxxxx>

Attachment: signature.asc
Description: This is a digitally signed message part