← Back to team overview

elementary-dev-community team mailing list archive

Review + Asisstentece for Scratch required!

 

Hi everyone, 

Most of you probably knows I have been following the project for
quite a long time. I have done some translation suggestions and some bug
reporting, but not much other then that.
Due to availability I can now focus on helping out more, including code.
Which I already did to scratch and pantheon-terminal.

While fixing a bug in scratch I had to compile scratch to test it, just
regular procedure. It's when I start panicking , I see a large amount of
Warnings, which I tried to initially ignore, because they weren't
related with files i have edited.
But it got stuck in my mind. So after preparing the patch branch and
proposing the merge I decided to investigate them a little further.

I found from unhandled errors, unused variables to unreachable code.
And these are vala [level] code.

So for me that's pretty serious... 

Decided to help out and make good use of my free time, here I go try to
fix this issues and find logical errors in certain functions. The weird
thing is that the functions that are affected by this have some
fundamental responsibilities to other parts of the project, which leads
me to think that if scratch works, it probably means that somewhere
somehow the rest of the code also uses and expects the "incorrect"
result of such functions...

So please I need your help. Maintainers...

Thanks in advance



-- 
Darcy Brás da Silva <dardevelin@xxxxxxxxxxxxxx>

Attachment: signature.asc
Description: This is a digitally signed message part


Follow ups