← Back to team overview

elementary-dev-community team mailing list archive

Re: Granite's IconFactory

 

Do you know how hard it would be to make Files stop using IconFactory.vala?


On Mon, Apr 1, 2013 at 7:45 PM, Mario Guerriero <mefrio.g@xxxxxxxxx> wrote:

> Files is using it.
> —
> Sent from Mailbox <https://bit.ly/SZvoJe> for iPhone
>
>
> On Mon, Apr 1, 2013 at 8:25 PM, Chris Timberlake <game64@xxxxxxxxx> wrote:
>
>> Is there a way to add compile time warnings to it?
>>
>> In the event developers are using it and are unknowing? I'm not
>> knowledgeable about adding compile time warnings in Vala but it might be
>> worth it.
>> On Apr 1, 2013 11:23 AM, "Sergey "Shnatsel" Davidoff" <
>> sergey@xxxxxxxxxxxxxxxx> wrote:
>>
>>> I suggest deprecating it instead of removing it right away.
>>>
>>>
>>> 2013/4/1 David Gomes <david@xxxxxxxxxxxxxxxx>
>>>
>>>> I can only remove it when Noise stops using it.
>>>>
>>>>
>>>> On Mon, Apr 1, 2013 at 7:21 PM, Victor <victoreduardm@xxxxxxxxx> wrote:
>>>>
>>>>> I'm sure Mario has used it in many of his projects.
>>>>>
>>>>> In my humble opinion, that class it not a big deal. It's only a
>>>>> wrapper/facade around one method from GTK+.
>>>>>
>>>>> Would you mind removing the StatusBar class too? It is hacky, ugly and
>>>>> incomplete and only Noise is using it.
>>>>>
>>>>> On Mon, Apr 1, 2013 at 12:06 PM, David Gomes <david@xxxxxxxxxxxxxxxx>
>>>>> wrote:
>>>>>
>>>>> Hello there,
>>>>>
>>>>> There's a class/object/file in Granite called "IconFactory.vala", you
>>>>> can check it out here -
>>>>> http://bazaar.launchpad.net/~elementary-pantheon/granite/granite/view/head:/lib/Services/IconFactory.vala
>>>>> .
>>>>>
>>>>> Is anybody using it and definitely dependent on it?
>>>>>
>>>>> We're considering removing it and I need to know if it's necessary.
>>>>>
>>>>> Best regards,
>>>>> David "Munchor" Gomes
>>>>>
>>>>>
>>>>
>>>> --
>>>> Mailing list: https://launchpad.net/~elementary-dev-community
>>>> Post to     : elementary-dev-community@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~elementary-dev-community
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>>
>>>
>>>
>>> --
>>> Sergey "Shnatsel" Davidoff
>>> OS architect @ elementary
>>>
>>> --
>>> Mailing list: https://launchpad.net/~elementary-dev-community
>>> Post to     : elementary-dev-community@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~elementary-dev-community
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>
> --
> Mailing list: https://launchpad.net/~elementary-dev-community
> Post to     : elementary-dev-community@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~elementary-dev-community
> More help   : https://help.launchpad.net/ListHelp
>
>

Follow ups

References