elementary-dev-community team mailing list archive

[Raphael Isemann <teemperor@xxxxxxxxxxxxxx>]

Review: Needs Fixing

1. Instead of 

43  stdout.printf ("pantheon-terminal: ERROR: " + e.message + "\n");
44	 
45  return 0;

use

error (e.message);

2. Not sure about the relevant part in the code, but the dark GTK+ theme isn't active when you start the About-Dialog from the quicklist and no terminal-instance is already running. In this case the about-window uses the normal GTK+ theme (so, a white window in elementary).
-- 
https://code.launchpad.net/~elementary-dev-community/pantheon-terminal/fix-1329550/+merge/229683
Your team elementary Developer Community is subscribed to branch lp:~elementary-dev-community/pantheon-terminal/fix-1329550.