← Back to team overview

elementaryart team mailing list archive

[Bug 821843] Re: Have a "register" function instead of putting connection logic into constructor

 

** Changed in: libpantheon
       Status: Confirmed => Invalid

** Changed in: libpantheon
       Status: Invalid => In Progress

-- 
You received this bug notification because you are a member of
elementary desktop team, which is the registrant for Pantheon Library.
https://bugs.launchpad.net/bugs/821843

Title:
  Have a "register" function instead of putting connection logic into
  constructor

Status in Pantheon Library:
  In Progress

Bug description:
  Currently, all of the setup logic happens in the constructor. This is
  fine, but seems slightly awkward and also raises a warning that you're
  not doing anything with the plug other than instantiating it. So I
  propose:

  1. Create the plug subclass
  2. Instantiate
  3. Call .register()

  This keeps the most simplicity and ease of use possible while
  eliminating the error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/libpantheon/+bug/821843/+subscriptions


References