elementaryart team mailing list archive

Thread
Date

Re: [Merge] lp:~elementaryart/lightdm-webkit-greeter/fixes-ubuntu into lp:lightdm-webkit-greeter

To: mp+75399@xxxxxxxxxxxxxxxxxx
From: Robert Ancell <robert.ancell@xxxxxxxxxxxxx>
Date: Mon, 26 Sep 2011 07:22:34 -0000
In-reply-to: <20110914183931.23695.23193.launchpad@ackee.canonical.com>
Reply-to: mp+75399@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Could you split this into a merge request for lp:lightdm-webkit-greeter (the upstream project) and lp:~ubuntu-desktop/lightdm-webkit-greeter/ubuntu (the packaging).

Apart from that the changes are good, but please:
- Remove commented out code
- Remove any temporary debugging (note there is a debug line that will print users passwords to the log which is a big security issue)
- Check whitespace (no tabs, four space indent).
-- 
https://code.launchpad.net/~elementaryart/lightdm-webkit-greeter/fixes-ubuntu/+merge/75399
Your team elementary desktop team is subscribed to branch lp:~elementaryart/lightdm-webkit-greeter/fixes-ubuntu.

References

[Merge] lp:~elementaryart/lightdm-webkit-greeter/fixes-ubuntu into lp:lightdm-webkit-greeter
From: Fabian Thoma, 2011-09-14