← Back to team overview

elementaryart team mailing list archive

Re: [Merge] lp:~voluntatefaber/granite/contract-menu-with-icons into lp:granite

 

Review: Approve

In the future (i.e. before the next release), we could:
- Make a common interface for both ContractorView and ContractorMenu
- Make the mimetype optional
- Add some methods like reload_for_file (string file, string? mimetype = null)
- Use a foreach to browse contracts in ContractorMenu.

So, we can merge this branch, but it will be an unstable API, be warned ;)
-- 
https://code.launchpad.net/~voluntatefaber/granite/contract-menu-with-icons/+merge/93729
Your team elementaryart (old) is subscribed to branch lp:granite.


References