elementaryart team mailing list archive
-
elementaryart team
-
Mailing list archive
-
Message #01953
[Merge] lp:~mefrio-g/granite/fix-dynamic-notebook into lp:granite
Mario Guerriero has proposed merging lp:~mefrio-g/granite/fix-dynamic-notebook into lp:granite.
Requested reviews:
elementary Pantheon team (elementary-pantheon)
For more details, see:
https://code.launchpad.net/~mefrio-g/granite/fix-dynamic-notebook/+merge/98111
added a signal after the add_button clicking to allow everyone to add a custom widget as page of the tab
--
https://code.launchpad.net/~mefrio-g/granite/fix-dynamic-notebook/+merge/98111
Your team elementaryart (old) is subscribed to branch lp:granite.
=== modified file 'lib/Widgets/DynamicNotebook.vala'
--- lib/Widgets/DynamicNotebook.vala 2012-03-11 17:28:44 +0000
+++ lib/Widgets/DynamicNotebook.vala 2012-03-18 20:54:17 +0000
@@ -718,6 +718,7 @@
public class Granite.Widgets.DynamicNotebook : Gtk.Grid {
Granite.Widgets.Tabs tabs;
+ public signal void add_clicked ();
public signal void new_tab_created (Tab tab);
public signal void switch_page (Widget page, uint num);
@@ -743,7 +744,7 @@
add_eventbox.add (add_button);
add_eventbox.get_style_context ().add_class ("dynamic-notebook");
add_eventbox.get_style_context ().add_provider (Tabs.style_provider, Tabs.style_priority);
- add_button.clicked.connect ( () => { new_tab (); });
+ add_button.clicked.connect ( () => { add_clicked (); });
tabs = new Granite.Widgets.Tabs ();
tabs.hexpand = true;
attach (tabs, 0, 0, 1, 1);
Follow ups