elementaryart team mailing list archive

Thread
Date

Re: [Merge] lp:~tombeckmann/granite/new-about into lp:granite

To: Tom Beckmann <tombeckmann@xxxxxxxxx>
From: Victor Eduardo <victoreduardm@xxxxxxxxx>
Date: Sat, 28 Apr 2012 21:27:19 -0000
In-reply-to: <20120427140917.15745.86841.launchpad@ackee.canonical.com>
Reply-to: mp+103882@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Awesome work!

Just checked the code and tested the widget for a while and everything's working perfectly. Things to consider for future revisions:
1) Store and load the close-button pixbuf using the GResource API
2) Add the "show-close-button" property. Default: true.
3) Add a center-aligned label on the top in order to include the "title" property
-- 
https://code.launchpad.net/~tombeckmann/granite/new-about/+merge/103882
Your team elementaryart (old) is subscribed to branch lp:granite.

References

[Merge] lp:~tombeckmann/granite/new-about into lp:granite
From: Tom Beckmann, 2012-04-27