enterprise-support team mailing list archive

[Laurynas Biveinis <laurynas.biveinis@xxxxxxxxx>]

Public bug reported:

Copy of http://bugs.mysql.com/bug.php?id=80496:

[24 Feb 14:00] Laurynas Biveinis
Description:
This is a minor code review type of bug:

buf_dblwr_init_or_load_pages, previously a void function, now returns a
dberr_t since [1]. But its sole caller does not bother to check it.

[1]:

commit 98909cefbc37e54efc6452c7e95bccbf64ac9213
Author: Sunny Bains <Sunny.Bains@xxxxxxxxxx>
Date:   Wed Mar 4 13:58:59 2015 +1100

    WL#7696 - Backport code from mysql-trunk to mysql-5.7

How to repeat:
Grep for buf_dblwr_init_or_load_pages

Suggested fix:
Check the return code in SysTablespace::read_lsn_and_check_flags, add attribute warn_unused_result.

** Affects: mysql-server
     Importance: Unknown
         Status: Unknown

** Affects: percona-server
     Importance: Undecided
         Status: Invalid

** Affects: percona-server/5.5
     Importance: Undecided
         Status: Invalid

** Affects: percona-server/5.6
     Importance: Undecided
         Status: Invalid

** Affects: percona-server/5.7
     Importance: Low
     Assignee: Laurynas Biveinis (laurynas-biveinis)
         Status: Fix Committed


** Tags: innodb low-hanging-fruit upstream

** Also affects: percona-server/5.5
   Importance: Undecided
       Status: New

** Also affects: percona-server/5.7
   Importance: Undecided
       Status: New

** Also affects: percona-server/5.6
   Importance: Undecided
       Status: New

** Changed in: percona-server/5.5
       Status: New => Opinion

** Changed in: percona-server/5.6
       Status: New => Invalid

** Changed in: percona-server/5.5
       Status: Opinion => Invalid

** Changed in: percona-server/5.7
       Status: New => Fix Committed

** Changed in: percona-server/5.7
   Importance: Undecided => Low

** Changed in: percona-server/5.7
     Assignee: (unassigned) => Laurynas Biveinis (laurynas-biveinis)

** Tags added: innodb low-hanging-fruit upstream

** Bug watch added: MySQL Bug System #80496
   http://bugs.mysql.com/bug.php?id=80496

** Also affects: mysql-server via
   http://bugs.mysql.com/bug.php?id=80496
   Importance: Unknown
       Status: Unknown

-- 
You received this bug notification because you are a member of Ubuntu
Server/Client Support Team, which is subscribed to MySQL.
Matching subscriptions: Ubuntu Server/Client Support Team
https://bugs.launchpad.net/bugs/1549301

Title:
  buf_dblwr_init_or_load_pages now returns an error code, but caller not
  updated

To manage notifications about this bug go to:
https://bugs.launchpad.net/mysql-server/+bug/1549301/+subscriptions