enterprise-support team mailing list archive

[George Ormond Lorch III <george.lorch@xxxxxxxxxxx>]

Public bug reported:

MyRocks testing needs some upstream Facebook MySQL patches in Percona
Server. These patches also correct a basic issue with <charset>_bin
ordering for both InnoDB and TokuDB.

Patches are:
https://github.com/facebook/mysql-5.6/commit/3fda3eb9bc7f7c5fec6ff2edd4057b7101102d69
Fix sort order for empty strings in 'text' columns
Summary:
This is a fix for an upstream bug: http://bugs.mysql.com/bug.php?id=81810

The problem is that Field_blob::make_sort_key will memzero the sort key
for the empty string. However, for most collations, the empty string
should sort as spaces, not as NUL characters.

The fix is to memzero only if the collation pad character happens to be
0 as well.

and

https://github.com/facebook/mysql-5.6/commit/fecef54c24b5b64037af1ecf2f8e6ced5a90a3ac
Fix length in Field_blob::make_sort_key
Summary:
For the binary collation in Field_blob::make_sort_key, we write out the length of the entire blob, even though the key itself may be shorter. We can miss out on duplicate key errors because of this:

Suppose key length is 1, and we want to encode "ab", "a". Then we get
the following sort keys:

  'a' 0 2
  'a' 0 1

We want the two of them to produce the same key instead. To fix, define
key length to be the min of blob length and requested key length.


Upstream tracking issue https://bugs.mysql.com/bug.php?id=81810

** Affects: mysql-server
     Importance: Unknown
         Status: Unknown

** Affects: percona-server
     Importance: Medium
     Assignee: George Ormond Lorch III (gl-az)
         Status: In Progress

** Affects: percona-server/5.6
     Importance: Medium
     Assignee: George Ormond Lorch III (gl-az)
         Status: In Progress

** Affects: percona-server/5.7
     Importance: Medium
     Assignee: George Ormond Lorch III (gl-az)
         Status: In Progress

** Also affects: percona-server/5.6
   Importance: Undecided
       Status: New

** Also affects: percona-server/5.7
   Importance: Undecided
       Status: New

** Bug watch added: MySQL Bug System #81810
   http://bugs.mysql.com/bug.php?id=81810

** Also affects: mysql-server via
   http://bugs.mysql.com/bug.php?id=81810
   Importance: Unknown
       Status: Unknown

** Changed in: percona-server/5.6
       Status: New => In Progress

** Changed in: percona-server/5.7
       Status: New => In Progress

** Changed in: percona-server/5.6
   Importance: Undecided => Medium

** Changed in: percona-server/5.7
   Importance: Undecided => Medium

** Changed in: percona-server/5.6
     Assignee: (unassigned) => George Ormond Lorch III (gl-az)

** Changed in: percona-server/5.7
     Assignee: (unassigned) => George Ormond Lorch III (gl-az)

-- 
You received this bug notification because you are a member of Ubuntu
Server/Client Support Team, which is subscribed to MySQL.
Matching subscriptions: Ubuntu Server/Client Support Team
https://bugs.launchpad.net/bugs/1674867

Title:
  MyRocks - missing server binary collation patch

To manage notifications about this bug go to:
https://bugs.launchpad.net/mysql-server/+bug/1674867/+subscriptions