← Back to team overview

ffc team mailing list archive

Re: bug in simplify?

 

Kristian Oelgaard wrote:
Quoting Marie Rognes <meg@xxxxxxxxxxx>:


However, this time it is actually not simplify that is the main culprit:

    After index reassignment:
0.5 | vi0[0]*vi1[0]*dX(0) + 0.5 | vi0[0]*vi1[0]*dX(0) + 0.5 |
    vi0[1]*vi1[1]*dX(0) + 0.5 | vi0[1]*vi1[2]*dX(0) + 0.5 |
    vi0[2]*vi1[2]*dX(0) + 0.5 | vi0[2]*vi1[1]*dX(0) + 0.5 |
    vi0[3]*vi1[3]*dX(0) + 0.5 | vi0[3]*vi1[3]*dX(0)
After simplification: 0.5 | vi0[b0]*vi1[b0]*dX(0) + 0.5 | vi0[b0]*vi1[b0]*dX(0) +
    0.5 | vi0[1]*vi1[2]*dX(0) + 0.5 | vi0[2]*vi1[1]*dX(0)


where the index b0 has range [0, 1, 2, 3] in the first term and [0, 3] in the second term. This makes sense.

Maybe, on a side note: the fact that 'b0' can have a different range in each
monomial makes it pretty difficult to debug/understand what is going on by just
looking at the pretty print version of the form. The index should be different
in my opinion.


Agree. Maybe we could have two versions of printing indices, one with the ranges (if set) ala

   b0 (0, 1, 2, 3)

for debug purposes and a denser one for non-debug purposes?

Actually, that would be a starting point for an accurate factorization check too.


--
Marie E. Rognes
Ph.D Fellow, Centre of Mathematics for Applications, University of Oslo
http://folk.uio.no/meg



Follow ups

References