← Back to team overview

ffc team mailing list archive

[HG FFC] Bug fix in simple_verify_tensors and update reference values.

 

One or more new changesets pushed to the primary ffc repository.
A short summary of the last three changesets is included below.

changeset:   1482:fd13957f73b480d4b86c605b24e2d5265aec91e8
tag:         tip
user:        Anders Logg <logg@xxxxxxxxx>
date:        Thu Mar 26 14:40:35 2009 +0100
files:       test/simple_verify_tensors/reference.pickle test/simple_verify_tensors/test.py
description:
Bug fix in simple_verify_tensors and update reference values.
All looks ok now. Three demos should fail with quadrature.
Comments from Kristian:

FunctionOperatorsBilinearForm_cell_integral_0:    *** (diff = 0.010091)

  The reason for the 'error' is that the old FFC interprets

  1/f := basis*1/w[*][*]

  where the new FFC (quadrature) does:

  1/f = 1/(basis*w[*][*])

MassBilinearForm_cell_integral_0:                 *** (diff = 1e-09)

  The code is correct, the old quadrature has a similar discrepancy. I think it is
  because we have 64 quadrature points (tabulated values) that are multiplied and
  the tensor contraction does this in Python and only used one value for the
  basis in the generated code.

QuadratureElementBilinearForm_cell_integral_0:    *** (diff = 0.249892)
QuadratureElementLinearForm_cell_integral_0:      *** (diff = 0.10106)

  This is because the old FFC interprets element = QE("triangle", 3) as a 3x3
  quadrature scheme, but for the new FFC '3' is the order and it will use a 2x2
  scheme for the evaluation.


changeset:   1481:1f63116b6e18445b11b1bc17875af24495cddf64
user:        "Kristian Oelgaard <k.b.oelgaard@xxxxxxxxxx>"
date:        Thu Mar 26 11:36:13 2009 +0100
files:       TODO ffc/compiler/codegeneration/quadrature/reduce_operations2.py ffc/compiler/codegeneration/quadrature/uflquadraturegenerator.py ffc/compiler/codegeneration/quadrature/uflquadraturegenerator_utils2.py test/simple_verify_tensors/reference.pickle
description:
Updated references in simple_verify_tensors.


changeset:   1480:d9ded590aae547a520fee35eeb9a90a506c6ac5c
user:        "Kristian Oelgaard <k.b.oelgaard@xxxxxxxxxx>"
date:        Wed Mar 25 10:28:16 2009 +0100
files:       ffc/compiler/codegeneration/quadrature/uflquadraturegenerator.py test/simple_verify_tensors/test.py test/verify_tensors/test.py
description:
Small updates for tests.

----------------------------------------------------------------------
For more details, visit http://www.fenics.org/hg/ffc